Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-23 21:30:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

Layout: Implement CSS Grid using taffy (#32619)

Browse source 
* Add layout.grid.enabled pref

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Add taffy dependency

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Import taffy <-> stylo conversion code from taffy_stylo crate

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Add `Grid` variant to DisplayInside

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Implement CSS Grid using Taffy

Signed-off-by: Nico Burns <nico@nicoburns.com>

Import full stylo_taffy crate

Signed-off-by: Nico Burns <nico@nicoburns.com>

Squashed PR feedback changes

Deduplicate is_document_only_whitespace

Signed-off-by: Nico Burns <nico@nicoburns.com>

Import taffy::AvailableSpace

Signed-off-by: Nico Burns <nico@nicoburns.com>

Rename FlexContext to TaffyContainerContext

Signed-off-by: Nico Burns <nico@nicoburns.com>

Eliminate references to flexbox in taffy/layout module

Signed-off-by: Nico Burns <nico@nicoburns.com>

Use constructors for geom types

Signed-off-by: Nico Burns <nico@nicoburns.com>

Remove comment about abspos elements splitting contiguous text runs

Signed-off-by: Nico Burns <nico@nicoburns.com>

Remove reference to flexbox in taffy/construct

Signed-off-by: Nico Burns <nico@nicoburns.com>

Deduplicate construction of flexbox/grid containers

Signed-off-by: Nico Burns <nico@nicoburns.com>

Make anonymous text runs InFlow

Signed-off-by: Nico Burns <nico@nicoburns.com>

Remove commented code

Signed-off-by: Nico Burns <nico@nicoburns.com>

Update comments

Signed-off-by: Nico Burns <nico@nicoburns.com>

Inline/vendor the stylo/taffy interop code

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Update test expectations

Signed-off-by: Nico Burns <nico@nicoburns.com>

* Fix nits from PR review

Signed-off-by: Nico Burns <nico@nicoburns.com>

---------

Signed-off-by: Nico Burns <nico@nicoburns.com>
This commit is contained in:
Nico Burns 2024-11-22 09:21:01 +13:00 • committed by GitHub
parent 339062c890
commit 6cbd89dbb0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
508 changed files with 2057 additions and 10408 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/wpt/meta/css/css-grid/grid-definition/grid-support-flexible-lengths-001.html.ini vendored
View file

@ -137,50 +137,26 @@
['grid' with: grid-template-columns: [a\] repeat(4, [b\] 1fr [c\]) [d\]; and grid-template-rows: [z\] repeat(4, [y\] 1fr) [x\];]
expected: FAIL
['emptyGrid' with: grid-template-columns: fr; and grid-template-rows: fr;]
expected: FAIL
['grid' with: grid-template-columns: fr; and grid-template-rows: fr;]
expected: FAIL
['emptyGrid' with: grid-template-columns: 1 fr; and grid-template-rows: 1 fr;]
expected: FAIL
['grid' with: grid-template-columns: 1 fr; and grid-template-rows: 1 fr;]
expected: FAIL
['emptyGrid' with: grid-template-columns: 1free-space; and grid-template-rows: 1free-space;]
expected: FAIL
['grid' with: grid-template-columns: 1free-space; and grid-template-rows: 1free-space;]
expected: FAIL
['emptyGrid' with: grid-template-columns: -2fr; and grid-template-rows: -2fr;]
expected: FAIL
['grid' with: grid-template-columns: -2fr; and grid-template-rows: -2fr;]
expected: FAIL
['emptyGrid' with: grid-template-columns: 0,5fr; and grid-template-rows: 0,5fr;]
expected: FAIL
['grid' with: grid-template-columns: 0,5fr; and grid-template-rows: 0,5fr;]
expected: FAIL
['emptyGrid' with: grid-template-columns: calc(1fr + 100px); and grid-template-rows: calc(1fr + 100px);]
expected: FAIL
['grid' with: grid-template-columns: calc(1fr + 100px); and grid-template-rows: calc(1fr + 100px);]
expected: FAIL
['emptyGrid' with: grid-template-columns: (1fr) auto; and grid-template-rows: (1fr) auto;]
expected: FAIL
['grid' with: grid-template-columns: (1fr) auto; and grid-template-rows: (1fr) auto;]
expected: FAIL
['emptyGrid' with: grid-template-columns: minmax(1fr, 1000px); and grid-template-rows: minmax(1fr, 700px);]
expected: FAIL
['grid' with: grid-template-columns: minmax(1fr, 1000px); and grid-template-rows: minmax(1fr, 700px);]
expected: FAIL