diff --git a/src/components/main/compositing/compositor.rs b/src/components/main/compositing/compositor.rs index 7add72d2a0c..f2a86e9ad81 100644 --- a/src/components/main/compositing/compositor.rs +++ b/src/components/main/compositing/compositor.rs @@ -93,7 +93,10 @@ pub struct IOCompositor { constellation_chan: ConstellationChan, /// The channel on which messages can be sent to the profiler. - profiler_chan: ProfilerChan + profiler_chan: ProfilerChan, + + /// Pending scroll to fragment event, if any + fragment_point: Option> } impl IOCompositor { @@ -129,7 +132,8 @@ impl IOCompositor { zoom_time: 0f64, compositor_layer: None, constellation_chan: constellation_chan.clone(), - profiler_chan: profiler_chan + profiler_chan: profiler_chan, + fragment_point: None } } @@ -329,21 +333,22 @@ impl IOCompositor { id: PipelineId, new_size: Size2D, epoch: Epoch) { - let ask: bool = match self.compositor_layer { + let (ask, move): (bool, bool) = match self.compositor_layer { Some(ref mut layer) => { let window_size = &self.window_size; let world_zoom = self.world_zoom; let page_window = Size2D(window_size.width as f32 / world_zoom, window_size.height as f32 / world_zoom); assert!(layer.resize(id, new_size, page_window, epoch)); - true - } - None => { - false + let move = self.fragment_point.take().map_default(false, |point| layer.move(point, page_window)); + + (true, move) } + None => (false, false) }; if ask { + self.recomposite_if(move); self.ask_for_tiles(); } } @@ -431,19 +436,20 @@ impl IOCompositor { let world_zoom = self.world_zoom; let page_window = Size2D(self.window_size.width as f32 / world_zoom, self.window_size.height as f32 / world_zoom); - let ask: bool = match self.compositor_layer { - Some(ref mut layer) if layer.pipeline.id == id => { - let recomposite = layer.move(point, page_window) | self.recomposite; - self.recomposite = recomposite; + let (ask, move): (bool, bool) = match self.compositor_layer { + Some(ref mut layer) if layer.pipeline.id == id && !layer.hidden => { - true + (true, layer.move(point, page_window)) } Some(_) | None => { - false + self.fragment_point = Some(point); + + (false, false) } }; if ask { + self.recomposite_if(move); self.ask_for_tiles(); } } @@ -535,10 +541,11 @@ impl IOCompositor { cursor.y as f32 / world_zoom); let page_window = Size2D(self.window_size.width as f32 / world_zoom, self.window_size.height as f32 / world_zoom); + let mut scroll = false; for layer in self.compositor_layer.mut_iter() { - let recomposite = layer.scroll(page_delta, page_cursor, page_window) || self.recomposite; - self.recomposite = recomposite; + scroll = layer.scroll(page_delta, page_cursor, page_window) || scroll; } + self.recomposite_if(scroll); self.ask_for_tiles(); } @@ -650,4 +657,8 @@ impl IOCompositor { self.done = true; } } + + fn recomposite_if(&mut self, result: bool) { + self.recomposite = result || self.recomposite; + } }