Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-02 12:10:29 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make sure input value=12:30:01 doesn't turn into 12:30:1

Browse source
This commit is contained in:
Patrick Shaughnessy 2020-01-11 14:19:37 -05:00
parent 419954474b
commit 6dc8f67f8f
3 changed files with 70 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/bindings/str.rs
View file

@ -474,7 +474,15 @@ impl DOMString {
"{:04}-{:02}-{:02}T{:02}:{:02}", "{:04}-{:02}-{:02}T{:02}:{:02}",
year, month, day, hour, minute year, month, day, hour, minute
); );
} else if second < 10.0 {
// we need exactly one leading zero on the seconds,
// whatever their total string length might be
self.0 = format!(
"{:04}-{:02}-{:02}T{:02}:{:02}:0{}",
year, month, day, hour, minute, second
);
} else { } else {
// we need no leading zeroes on the seconds
self.0 = format!( self.0 = format!(
"{:04}-{:02}-{:02}T{:02}:{:02}:{}", "{:04}-{:02}-{:02}T{:02}:{:02}:{}",
year, month, day, hour, minute, second year, month, day, hour, minute, second

10
tests/wpt/metadata/MANIFEST.json
View file

@ -369990,6 +369990,12 @@
{} {}
] ]
], ],
"html/semantics/forms/the-input-element/input-seconds-leading-zeroes.html": [
[
"html/semantics/forms/the-input-element/input-seconds-leading-zeroes.html",
{}
]
],
"html/semantics/forms/the-input-element/input-setcustomvalidity.html": [ "html/semantics/forms/the-input-element/input-setcustomvalidity.html": [
[ [
"html/semantics/forms/the-input-element/input-setcustomvalidity.html", "html/semantics/forms/the-input-element/input-setcustomvalidity.html",
@ -693507,6 +693513,10 @@
"006a8fbd8f1b84d18e9ec29285f751f037118389", "006a8fbd8f1b84d18e9ec29285f751f037118389",
"testharness" "testharness"
], ],
"html/semantics/forms/the-input-element/input-seconds-leading-zeroes.html": [
"d94bee10296da58ba700b4e7a910f9e0821c82ef",
"testharness"
],
"html/semantics/forms/the-input-element/input-setcustomvalidity.html": [ "html/semantics/forms/the-input-element/input-setcustomvalidity.html": [
"accb24d8f9564f97e12bf4784162ff3cd00f35af", "accb24d8f9564f97e12bf4784162ff3cd00f35af",
"testharness" "testharness"

52
tests/wpt/web-platform-tests/html/semantics/forms/the-input-element/input-seconds-leading-zeroes.html Normal file
View file

@ -0,0 +1,52 @@
<!DOCTYPE HTML>
<meta charset="utf-8">
<html>
<head>
<title>HTMLInputElement leading zeroes in seconds/millis</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
</head>
<body>
<h3>input times and datetimes with leading zeroes in seconds/millis</h3>
<!-- This test ensures that seconds and milliseconds are being
output with the appropriate field widths when sanitizing
datetime-locals and times, e.g. that we don't see "12:30:1".
The spec is not specific about how much precision to use
in a sanitized time string, but an invalid string would
fail at .valueAsNumber -->
<hr>
<div id="log"></div>
<input id="inp">
<script>
var inp=document.getElementById("inp");
var cases = [
["datetime-local", "2000-01-01T12:30:01", 946729801000],
["datetime-local", "2000-01-01T12:30:00.5", 946729800500],
["datetime-local", "2000-01-01T12:30:00.04", 946729800040],
["datetime-local", "2000-01-01T12:30:00.003", 946729800003],
["time", "12:30:01", 45001000],
["time", "12:30:00.5", 45000500],
["time", "12:30:00.04", 45000040],
["time", "12:30:00.003", 45000003],
];
for (var i in cases) {
var c = cases[i];
test(function() {
inp.setAttribute("type", c[0]);
inp.value = c[1];
assert_equals(inp.valueAsNumber, c[2]);
},"Expected valueAsNumber=" +c[2] + " from " + c[1]);
if (c[0] == "datetime-local") {
test(function() {
inp.setAttribute("type", c[0]);
inp.value = c[1];
assert_in_array(inp.value, [c[1], c[1].replace("T", " ")]);
},"Expected digits unchanged in round-trip of " + c[1])
}
}
</script>
</body>
</html>