Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Use Au::abs.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2017-08-18 10:09:09 +02:00
parent 7bf1748c34
commit 6df597b0b8
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
2 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/style/values/computed/length.rs
View file

@ -206,11 +206,8 @@ impl ToCss for CalcLengthOrPercentage {
percentage.to_css(dest)?; percentage.to_css(dest)?;
dest.write_str(if length < Zero::zero() { " - " } else { " + " })?; dest.write_str(if length < Zero::zero() { " - " } else { " + " })?;
length.abs().to_css(dest)?;
// FIXME(emilio): Au::abs would be nice.
let length = if length < Zero::zero() { -length } else { length };
length.to_css(dest)?;
dest.write_str(")") dest.write_str(")")
} }
} }

6
components/style/values/specified/calc.rs
View file

@ -91,6 +91,8 @@ impl HasViewportPercentage for CalcLengthOrPercentage {
impl ToCss for CalcLengthOrPercentage { impl ToCss for CalcLengthOrPercentage {
/// https://drafts.csswg.org/css-values/#calc-serialize /// https://drafts.csswg.org/css-values/#calc-serialize
///
/// FIXME(emilio): Should this simplify away zeros?
#[allow(unused_assignments)] #[allow(unused_assignments)]
fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write { fn to_css<W>(&self, dest: &mut W) -> fmt::Result where W: fmt::Write {
use num_traits::Zero; use num_traits::Zero;
@ -143,9 +145,7 @@ impl ToCss for CalcLengthOrPercentage {
if let Some(val) = self.absolute { if let Some(val) = self.absolute {
first_value_check!(val); first_value_check!(val);
// FIXME(emilio): Au::abs() would be nice. val.abs().to_css(dest)?;
let abs = if val < Zero::zero() { -val } else { val };
abs.to_css(dest)?;
} }
serialize!(rem, vh, vmax, vmin, vw); serialize!(rem, vh, vmax, vmin, vw);