Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #7288 - mdibaiee:computedstyle-element, r=Ms2ger

Browse source 
Fix #7268 - getComputedStyle should take `Element`, not `HTMLElement`

This is my first patch, I hope I'm doing it right.

About the test, do you think this is enough and reliable?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7288)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-08-22 20:43:45 -06:00
commit 6e06cae44a
7 changed files with 40 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/wpt/metadata/MANIFEST.json
View file

@ -29097,7 +29097,14 @@
]
},
"local_changes": {
"deleted": [],
"deleted": [
"shadow-dom/shadow-trees/hosting-multiple-shadow-trees-002.html",
"shadow-dom/shadow-trees/hosting-multiple-shadow-trees-006.html",
"shadow-dom/shadow-trees/hosting-multiple-shadow-trees-004.html",
"shadow-dom/shadow-trees/hosting-multiple-shadow-trees-003.html",
"2dcontext/transformations/canvas_transformations_reset_001.htm",
"shadow-dom/shadow-trees/hosting-multiple-shadow-trees-005.html"
],
"items": {},
"reftest_nodes": {}
},

6
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -485,6 +485,12 @@
"url": "/_mozilla/mozilla/element_className.html"
}
],
"mozilla/element_getcomputedstyle.html": [
{
"path": "mozilla/element_getcomputedstyle.html",
"url": "/_mozilla/mozilla/element_getcomputedstyle.html"
}
],
"mozilla/element_matches.html": [
{
"path": "mozilla/element_matches.html",

18
tests/wpt/mozilla/tests/mozilla/element_getcomputedstyle.html Normal file
View file

@ -0,0 +1,18 @@
<html>
<head>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
</head>
<body>
<script>
// Issue #7268 - getComputedStyle should work on non-HTML elements, too
test(function() {
var el = document.createElementNS("http://example.com", "a");
document.body.appendChild(el);
var style = window.getComputedStyle(el);
assert_equals(style.opacity, "1");
}, "getComputedStyle should work on non-HTML elements");
</script>
</body>
</html>