From 6e2d1bdc7932b50e8c6e0f20a05096c6b5863467 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Thu, 18 May 2023 09:08:43 +0200 Subject: [PATCH] Thread panics should be a hard-fail in smoketests This prevents, for instance, a script thread panic from hanging Servo and means those kind of panics won't cause CI to hang. Fixes #29749. --- python/servo/testing_commands.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 9209e9240d8..01c5882ca2c 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -835,6 +835,9 @@ testing/web-platform/mozilla/tests for Servo-only tests""" % reference_path) @CommandArgument('params', nargs='...', help="Command-line arguments to be passed through to Servo") def smoketest(self, params): - params = params + ['tests/html/close-on-load.html'] + # We pass `-f` here so that any thread panic will cause Servo to exit, + # preventing a panic from hanging execution. This means that these kind + # of panics won't cause timeouts on CI. + params = params + ['-f', 'tests/html/close-on-load.html'] return self.context.commands.dispatch( 'run', self.context, params=params)