Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reuse StylesheetContent for inline style sheets with identical content (#38540)

Browse source 
For duplicate style sheets with identical content, `StylesheetContents`
can be reused to avoid redundant parsing of the inline style sheets.
Since duplicate stylesheets is a common case with web components, this
change will significantly improve performance. Additionally, the cache
hit rate of stylo's `CascadeDataCache` can now be significantly
improved.

When shared `StylesheetContents` is modified, copy-on-write will occur
to avoid affecting other sharers. And then updates the references to
`CssRule` or `PropertyDeclarationBlock` stored in the CSSOMs to ensure
that modifications are made only on the new copy.

Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
This commit is contained in:
JoeDow 2025-08-20 20:31:49 +08:00 • committed by GitHub
parent f6b77f94e2
commit 6e6ef513a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 711 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

22
components/script/dom/csskeyframerule.rs
View file

@ -2,9 +2,11 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::cell::RefCell;
use dom_struct::dom_struct;
use servo_arc::Arc;
use style::shared_lock::{Locked, ToCssWithGuard};
use style::shared_lock::{Locked, SharedRwLockReadGuard, ToCssWithGuard};
use style::stylesheets::CssRuleType;
use style::stylesheets::keyframes_rule::Keyframe;
@ -24,7 +26,7 @@ pub(crate) struct CSSKeyframeRule {
cssrule: CSSRule,
#[ignore_malloc_size_of = "Arc"]
#[no_trace]
keyframerule: Arc<Locked<Keyframe>>,
keyframerule: RefCell<Arc<Locked<Keyframe>>>,
style_decl: MutNullableDom<CSSStyleDeclaration>,
}
@ -35,7 +37,7 @@ impl CSSKeyframeRule {
) -> CSSKeyframeRule {
CSSKeyframeRule {
cssrule: CSSRule::new_inherited(parent_stylesheet),
keyframerule,
keyframerule: RefCell::new(keyframerule),
style_decl: Default::default(),
}
}
@ -56,6 +58,17 @@ impl CSSKeyframeRule {
can_gc,
)
}
pub(crate) fn update_rule(
&self,
keyframerule: Arc<Locked<Keyframe>>,
guard: &SharedRwLockReadGuard,
) {
if let Some(ref style_decl) = self.style_decl.get() {
style_decl.update_property_declaration_block(&keyframerule.read_with(guard).block);
}
*self.keyframerule.borrow_mut() = keyframerule;
}
}
impl CSSKeyframeRuleMethods<crate::DomTypeHolder> for CSSKeyframeRule {
@ -67,7 +80,7 @@ impl CSSKeyframeRuleMethods<crate::DomTypeHolder> for CSSKeyframeRule {
self.global().as_window(),
CSSStyleOwner::CSSRule(
Dom::from_ref(self.upcast()),
self.keyframerule.read_with(&guard).block.clone(),
RefCell::new(self.keyframerule.borrow().read_with(&guard).block.clone()),
),
None,
CSSModificationAccess::ReadWrite,
@ -85,6 +98,7 @@ impl SpecificCSSRule for CSSKeyframeRule {
fn get_css(&self) -> DOMString {
let guard = self.cssrule.shared_lock().read();
self.keyframerule
.borrow()
.read_with(&guard)
.to_css_string(&guard)
.into()