Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reuse StylesheetContent for inline style sheets with identical content (#38540)

Browse source 
For duplicate style sheets with identical content, `StylesheetContents`
can be reused to avoid redundant parsing of the inline style sheets.
Since duplicate stylesheets is a common case with web components, this
change will significantly improve performance. Additionally, the cache
hit rate of stylo's `CascadeDataCache` can now be significantly
improved.

When shared `StylesheetContents` is modified, copy-on-write will occur
to avoid affecting other sharers. And then updates the references to
`CssRule` or `PropertyDeclarationBlock` stored in the CSSOMs to ensure
that modifications are made only on the new copy.

Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
This commit is contained in:
JoeDow 2025-08-20 20:31:49 +08:00 • committed by GitHub
parent f6b77f94e2
commit 6e6ef513a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 711 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/script/dom/cssnamespacerule.rs
View file

@ -2,6 +2,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::cell::RefCell;
use dom_struct::dom_struct;
use servo_arc::Arc;
use style::shared_lock::ToCssWithGuard;
@ -21,7 +23,7 @@ pub(crate) struct CSSNamespaceRule {
cssrule: CSSRule,
#[ignore_malloc_size_of = "Arc"]
#[no_trace]
namespacerule: Arc<NamespaceRule>,
namespacerule: RefCell<Arc<NamespaceRule>>,
}
impl CSSNamespaceRule {
@ -31,7 +33,7 @@ impl CSSNamespaceRule {
) -> CSSNamespaceRule {
CSSNamespaceRule {
cssrule: CSSRule::new_inherited(parent_stylesheet),
namespacerule,
namespacerule: RefCell::new(namespacerule),
}
}
@ -51,12 +53,17 @@ impl CSSNamespaceRule {
can_gc,
)
}
pub(crate) fn update_rule(&self, namespacerule: Arc<NamespaceRule>) {
*self.namespacerule.borrow_mut() = namespacerule;
}
}
impl CSSNamespaceRuleMethods<crate::DomTypeHolder> for CSSNamespaceRule {
// https://drafts.csswg.org/cssom/#dom-cssnamespacerule-prefix
fn Prefix(&self) -> DOMString {
self.namespacerule
.borrow()
.prefix
.as_ref()
.map(|s| s.to_string().into())
@ -65,7 +72,7 @@ impl CSSNamespaceRuleMethods<crate::DomTypeHolder> for CSSNamespaceRule {
// https://drafts.csswg.org/cssom/#dom-cssnamespacerule-namespaceuri
fn NamespaceURI(&self) -> DOMString {
(**self.namespacerule.url).into()
(**self.namespacerule.borrow().url).into()
}
}
@ -76,6 +83,6 @@ impl SpecificCSSRule for CSSNamespaceRule {
fn get_css(&self) -> DOMString {
let guard = self.cssrule.shared_lock().read();
self.namespacerule.to_css_string(&guard).into()
self.namespacerule.borrow().to_css_string(&guard).into()
}
}