Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reuse StylesheetContent for inline style sheets with identical content (#38540)

Browse source 
For duplicate style sheets with identical content, `StylesheetContents`
can be reused to avoid redundant parsing of the inline style sheets.
Since duplicate stylesheets is a common case with web components, this
change will significantly improve performance. Additionally, the cache
hit rate of stylo's `CascadeDataCache` can now be significantly
improved.

When shared `StylesheetContents` is modified, copy-on-write will occur
to avoid affecting other sharers. And then updates the references to
`CssRule` or `PropertyDeclarationBlock` stored in the CSSOMs to ensure
that modifications are made only on the new copy.

Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
This commit is contained in:
JoeDow 2025-08-20 20:31:49 +08:00 • committed by GitHub
parent f6b77f94e2
commit 6e6ef513a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 711 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

29
components/script/dom/cssnesteddeclarations.rs
View file

@ -2,9 +2,11 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::cell::RefCell;
use dom_struct::dom_struct;
use servo_arc::Arc;
use style::shared_lock::{Locked, ToCssWithGuard};
use style::shared_lock::{Locked, SharedRwLockReadGuard, ToCssWithGuard};
use style::stylesheets::{CssRuleType, NestedDeclarationsRule};
use crate::dom::bindings::codegen::Bindings::CSSNestedDeclarationsBinding::CSSNestedDeclarationsMethods;
@ -23,7 +25,7 @@ pub(crate) struct CSSNestedDeclarations {
cssrule: CSSRule,
#[ignore_malloc_size_of = "Arc"]
#[no_trace]
nesteddeclarationsrule: Arc<Locked<NestedDeclarationsRule>>,
nesteddeclarationsrule: RefCell<Arc<Locked<NestedDeclarationsRule>>>,
style_decl: MutNullableDom<CSSStyleDeclaration>,
}
@ -34,7 +36,7 @@ impl CSSNestedDeclarations {
) -> Self {
Self {
cssrule: CSSRule::new_inherited(parent_stylesheet),
nesteddeclarationsrule,
nesteddeclarationsrule: RefCell::new(nesteddeclarationsrule),
style_decl: Default::default(),
}
}
@ -55,6 +57,18 @@ impl CSSNestedDeclarations {
can_gc,
)
}
pub(crate) fn update_rule(
&self,
nesteddeclarationsrule: Arc<Locked<NestedDeclarationsRule>>,
guard: &SharedRwLockReadGuard,
) {
if let Some(ref style_decl) = self.style_decl.get() {
style_decl
.update_property_declaration_block(&nesteddeclarationsrule.read_with(guard).block);
}
*self.nesteddeclarationsrule.borrow_mut() = nesteddeclarationsrule;
}
}
impl SpecificCSSRule for CSSNestedDeclarations {
@ -65,6 +79,7 @@ impl SpecificCSSRule for CSSNestedDeclarations {
fn get_css(&self) -> DOMString {
let guard = self.cssrule.shared_lock().read();
self.nesteddeclarationsrule
.borrow()
.read_with(&guard)
.to_css_string(&guard)
.into()
@ -80,7 +95,13 @@ impl CSSNestedDeclarationsMethods<crate::DomTypeHolder> for CSSNestedDeclaration
self.global().as_window(),
CSSStyleOwner::CSSRule(
Dom::from_ref(self.upcast()),
self.nesteddeclarationsrule.read_with(&guard).block.clone(),
RefCell::new(
self.nesteddeclarationsrule
.borrow()
.read_with(&guard)
.block
.clone(),
),
),
None,
CSSModificationAccess::ReadWrite,