Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reuse StylesheetContent for inline style sheets with identical content (#38540)

Browse source 
For duplicate style sheets with identical content, `StylesheetContents`
can be reused to avoid redundant parsing of the inline style sheets.
Since duplicate stylesheets is a common case with web components, this
change will significantly improve performance. Additionally, the cache
hit rate of stylo's `CascadeDataCache` can now be significantly
improved.

When shared `StylesheetContents` is modified, copy-on-write will occur
to avoid affecting other sharers. And then updates the references to
`CssRule` or `PropertyDeclarationBlock` stored in the CSSOMs to ensure
that modifications are made only on the new copy.

Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
This commit is contained in:
JoeDow 2025-08-20 20:31:49 +08:00 • committed by GitHub
parent f6b77f94e2
commit 6e6ef513a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 711 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

70
components/script/dom/cssrule.rs
View file

@ -5,7 +5,7 @@
use std::cell::Cell;
use dom_struct::dom_struct;
use style::shared_lock::SharedRwLock;
use style::shared_lock::{SharedRwLock, SharedRwLockReadGuard};
use style::stylesheets::{CssRule as StyleCssRule, CssRuleType};
use crate::dom::bindings::codegen::Bindings::CSSRuleBinding::CSSRuleMethods;
@ -157,7 +157,73 @@ impl CSSRule {
}
pub(crate) fn shared_lock(&self) -> &SharedRwLock {
&self.parent_stylesheet.style_stylesheet().shared_lock
self.parent_stylesheet.shared_lock()
}
pub(crate) fn update_rule(&self, style_rule: &StyleCssRule, guard: &SharedRwLockReadGuard) {
match style_rule {
StyleCssRule::Import(s) => {
if let Some(rule) = self.downcast::<CSSImportRule>() {
rule.update_rule(s.clone());
}
},
StyleCssRule::Style(s) => {
if let Some(rule) = self.downcast::<CSSStyleRule>() {
rule.update_rule(s.clone(), guard);
}
},
StyleCssRule::FontFace(s) => {
if let Some(rule) = self.downcast::<CSSFontFaceRule>() {
rule.update_rule(s.clone());
}
},
StyleCssRule::FontFeatureValues(_) => unimplemented!(),
StyleCssRule::CounterStyle(_) => unimplemented!(),
StyleCssRule::Keyframes(s) => {
if let Some(rule) = self.downcast::<CSSKeyframesRule>() {
rule.update_rule(s.clone(), guard);
}
},
StyleCssRule::Media(s) => {
if let Some(rule) = self.downcast::<CSSMediaRule>() {
rule.update_rule(s.clone(), guard);
}
},
StyleCssRule::Namespace(s) => {
if let Some(rule) = self.downcast::<CSSNamespaceRule>() {
rule.update_rule(s.clone());
}
},
StyleCssRule::Supports(s) => {
if let Some(rule) = self.downcast::<CSSSupportsRule>() {
rule.update_rule(s.clone(), guard);
}
},
StyleCssRule::Page(_) => unreachable!(),
StyleCssRule::Container(_) => unimplemented!(), // TODO
StyleCssRule::Document(_) => unimplemented!(), // TODO
StyleCssRule::LayerBlock(s) => {
if let Some(rule) = self.downcast::<CSSLayerBlockRule>() {
rule.update_rule(s.clone(), guard);
}
},
StyleCssRule::LayerStatement(s) => {
if let Some(rule) = self.downcast::<CSSLayerStatementRule>() {
rule.update_rule(s.clone());
}
},
StyleCssRule::FontPaletteValues(_) => unimplemented!(), // TODO
StyleCssRule::Property(_) => unimplemented!(), // TODO
StyleCssRule::Margin(_) => unimplemented!(), // TODO
StyleCssRule::Scope(_) => unimplemented!(), // TODO
StyleCssRule::StartingStyle(_) => unimplemented!(), // TODO
StyleCssRule::PositionTry(_) => unimplemented!(), // TODO
StyleCssRule::NestedDeclarations(s) => {
if let Some(rule) = self.downcast::<CSSNestedDeclarations>() {
rule.update_rule(s.clone(), guard);
}
},
}
}
}