Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reuse StylesheetContent for inline style sheets with identical content (#38540)

Browse source 
For duplicate style sheets with identical content, `StylesheetContents`
can be reused to avoid redundant parsing of the inline style sheets.
Since duplicate stylesheets is a common case with web components, this
change will significantly improve performance. Additionally, the cache
hit rate of stylo's `CascadeDataCache` can now be significantly
improved.

When shared `StylesheetContents` is modified, copy-on-write will occur
to avoid affecting other sharers. And then updates the references to
`CssRule` or `PropertyDeclarationBlock` stored in the CSSOMs to ensure
that modifications are made only on the new copy.

Signed-off-by: sharpshooter_pt <ibluegalaxy_taoj@163.com>
This commit is contained in:
JoeDow 2025-08-20 20:31:49 +08:00 • committed by GitHub
parent f6b77f94e2
commit 6e6ef513a9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 711 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

22
components/script/dom/csssupportsrule.rs
View file

@ -2,9 +2,11 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use std::cell::RefCell;
use dom_struct::dom_struct;
use servo_arc::Arc;
use style::shared_lock::ToCssWithGuard;
use style::shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
use style::stylesheets::{CssRuleType, SupportsRule};
use style_traits::ToCss;
@ -22,7 +24,7 @@ pub(crate) struct CSSSupportsRule {
cssconditionrule: CSSConditionRule,
#[ignore_malloc_size_of = "Arc"]
#[no_trace]
supportsrule: Arc<SupportsRule>,
supportsrule: RefCell<Arc<SupportsRule>>,
}
impl CSSSupportsRule {
@ -33,7 +35,7 @@ impl CSSSupportsRule {
let list = supportsrule.rules.clone();
CSSSupportsRule {
cssconditionrule: CSSConditionRule::new_inherited(parent_stylesheet, list),
supportsrule,
supportsrule: RefCell::new(supportsrule),
}
}
@ -56,7 +58,17 @@ impl CSSSupportsRule {
/// <https://drafts.csswg.org/css-conditional-3/#the-csssupportsrule-interface>
pub(crate) fn get_condition_text(&self) -> DOMString {
self.supportsrule.condition.to_css_string().into()
self.supportsrule.borrow().condition.to_css_string().into()
}
pub(crate) fn update_rule(
&self,
supportsrule: Arc<SupportsRule>,
guard: &SharedRwLockReadGuard,
) {
self.cssconditionrule
.update_rules(supportsrule.rules.clone(), guard);
*self.supportsrule.borrow_mut() = supportsrule;
}
}
@ -67,6 +79,6 @@ impl SpecificCSSRule for CSSSupportsRule {
fn get_css(&self) -> DOMString {
let guard = self.cssconditionrule.shared_lock().read();
self.supportsrule.to_css_string(&guard).into()
self.supportsrule.borrow().to_css_string(&guard).into()
}
}