Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-08 08:33:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add check up on extern crate order and sort extern crates alphabetically

Browse source
This commit is contained in:
Guillaume Gomez 2015-11-26 01:23:11 +01:00
parent f96e8ce9e8
commit 6e7de62b38
22 changed files with 111 additions and 108 deletions
Download patch file Download diff file Expand all files Collapse all files

19
python/tidy.py
View file

@ -221,12 +221,25 @@ def check_rust(file_name, contents):
whitespace = False
uses = []
prev_crate = {}
mods = []
for idx, line in enumerate(contents):
for idx, original_line in enumerate(contents):
# simplify the analysis
line = line.strip()
line = original_line.strip()
# check extern crates
if line.startswith("extern crate"):
crate_name = line.replace("extern crate ", "").replace(";", "")
indent = len(original_line) - len(line)
if indent not in prev_crate:
prev_crate[indent] = ""
if prev_crate[indent] > crate_name:
message = "extern crate statement is not in alphabetical order"
expected = "\n\t\033[93mexpected: {}\033[0m".format(prev_crate[indent])
found = "\n\t\033[91mfound: {}\033[0m".format(crate_name)
yield(idx + 1, message + expected + found)
prev_crate[indent] = crate_name
# Simple heuristic to avoid common case of no comments.
if '/' in line: