From 6eb3e165787449492ee12f3bd1a6f8529356f7e6 Mon Sep 17 00:00:00 2001 From: XXIV <13811862+thechampagne@users.noreply.github.com> Date: Fri, 1 Sep 2023 07:44:24 +0300 Subject: [PATCH] remove unnecessary heap allocation (#30272) --- ports/libsimpleservo/capi/src/prefs.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ports/libsimpleservo/capi/src/prefs.rs b/ports/libsimpleservo/capi/src/prefs.rs index 70534084f57..a0fe302d0b5 100644 --- a/ports/libsimpleservo/capi/src/prefs.rs +++ b/ports/libsimpleservo/capi/src/prefs.rs @@ -41,7 +41,7 @@ impl LocalCPrefValue { match v { PrefValue::Float(v) => LocalCPrefValue::Float(*v), PrefValue::Int(v) => LocalCPrefValue::Int(*v), - PrefValue::Str(v) => LocalCPrefValue::Str(CString::new(v.clone()).unwrap()), + PrefValue::Str(v) => LocalCPrefValue::Str(CString::new(v.as_bytes()).unwrap()), PrefValue::Bool(v) => LocalCPrefValue::Bool(*v), PrefValue::Missing => LocalCPrefValue::Missing, } @@ -203,7 +203,7 @@ pub extern "C" fn get_prefs() -> CPrefList { .into_iter() .map(|(key, (value, is_default))| { let l = Box::new(LocalCPref { - key: CString::new(key.clone()).unwrap(), + key: CString::new(key.as_bytes()).unwrap(), value: LocalCPrefValue::new(&value), is_default: is_default, });