Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Rename various methods and members to conform to naming guidelines (#33762)

Browse source 
This ensure that methods named `new()` do not take `&self` or return
`Box<Self>`. In addition, method are renamed (or removed when not
necessary) to avoid being prefixed with `from_`.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2024-10-10 03:21:07 -07:00 • committed by GitHub
parent 2805d3ce14
commit 6f87c38cda
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 55 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

33
components/script/dom/workerglobalscope.rs
View file

@ -114,15 +114,14 @@ pub struct WorkerGlobalScope {
#[ignore_malloc_size_of = "Defined in ipc-channel"]
#[no_trace]
/// Optional `IpcSender` for sending the `DevtoolScriptControlMsg`
/// to the server from within the worker
from_devtools_sender: Option<IpcSender<DevtoolScriptControlMsg>>,
/// A `Sender` for sending messages to devtools. This is unused but is stored here to
/// keep the channel alive.
_devtools_sender: Option<IpcSender<DevtoolScriptControlMsg>>,
#[ignore_malloc_size_of = "Defined in std"]
#[ignore_malloc_size_of = "Defined in crossbeam"]
#[no_trace]
/// This `Receiver` will be ignored later if the corresponding
/// `IpcSender` doesn't exist
from_devtools_receiver: Receiver<DevtoolScriptControlMsg>,
/// A `Receiver` for receiving messages from devtools.
devtools_receiver: Option<Receiver<DevtoolScriptControlMsg>>,
#[no_trace]
navigation_start: CrossProcessInstant,
@ -137,12 +136,18 @@ impl WorkerGlobalScope {
worker_type: WorkerType,
worker_url: ServoUrl,
runtime: Runtime,
from_devtools_receiver: Receiver<DevtoolScriptControlMsg>,
devtools_receiver: Receiver<DevtoolScriptControlMsg>,
closing: Arc<AtomicBool>,
gpu_id_hub: Arc<IdentityHub>,
) -> Self {
// Install a pipeline-namespace in the current thread.
PipelineNamespace::auto_install();
let devtools_receiver = match init.from_devtools_sender {
Some(..) => Some(devtools_receiver),
None => None,
};
Self {
globalscope: GlobalScope::new_inherited(
init.pipeline_id,
@ -168,8 +173,8 @@ impl WorkerGlobalScope {
runtime: DomRefCell::new(Some(runtime)),
location: Default::default(),
navigator: Default::default(),
from_devtools_sender: init.from_devtools_sender,
from_devtools_receiver,
devtools_receiver,
_devtools_sender: init.from_devtools_sender,
navigation_start: CrossProcessInstant::now(),
performance: Default::default(),
}
@ -193,12 +198,8 @@ impl WorkerGlobalScope {
.prepare_for_new_child()
}
pub fn from_devtools_sender(&self) -> Option<IpcSender<DevtoolScriptControlMsg>> {
self.from_devtools_sender.clone()
}
pub fn from_devtools_receiver(&self) -> &Receiver<DevtoolScriptControlMsg> {
&self.from_devtools_receiver
pub fn devtools_receiver(&self) -> Option<&Receiver<DevtoolScriptControlMsg>> {
self.devtools_receiver.as_ref()
}
#[allow(unsafe_code)]