Auto merge of #26594 - mrobinson:animationiteration, r=jdm

Implement animationiteration event

This event is triggered when an animation iterates. This change also
moves iteration out of style calculation to an "update animations" which
is the next part of having animation event handling match the HTML spec.

This change causes a few more tests to pass. Some of the other tests which
exercise this functionality require `animationstart` events.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-05-21 10:11:45 -04:00 committed by GitHub
commit 70700c20ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 93 additions and 80 deletions

View file

@ -1,8 +1,5 @@
[animationevent-types.html]
expected: TIMEOUT
[animationiteration event is instanceof AnimationEvent]
expected: TIMEOUT
[animationstart event is instanceof AnimationEvent]
expected: TIMEOUT

View file

@ -1,7 +1,4 @@
[idlharness.html]
[HTMLElement interface: attribute onanimationiteration]
expected: FAIL
[HTMLElement interface: attribute onanimationstart]
expected: FAIL
@ -20,18 +17,12 @@
[Window interface: attribute onanimationstart]
expected: FAIL
[Window interface: attribute onanimationiteration]
expected: FAIL
[Document interface: attribute onanimationcancel]
expected: FAIL
[CSSKeyframeRule interface: attribute style]
expected: FAIL
[Document interface: attribute onanimationiteration]
expected: FAIL
[HTMLElement interface: attribute onanimationcancel]
expected: FAIL

View file

@ -1,9 +1,6 @@
[animationevent-types.html]
bug: https://github.com/servo/servo/issues/21564
expected: TIMEOUT
[animationiteration event is instanceof AnimationEvent]
expected: TIMEOUT
[animationstart event is instanceof AnimationEvent]
expected: TIMEOUT

View file

@ -1,16 +1,10 @@
[idlharness.html]
[Document interface: attribute onanimationiteration]
expected: FAIL
[CSSKeyframeRule interface: attribute style]
expected: FAIL
[Document interface: attribute onanimationstart]
expected: FAIL
[HTMLElement interface: attribute onanimationiteration]
expected: FAIL
[Window interface: attribute onanimationcancel]
expected: FAIL
@ -29,9 +23,6 @@
[HTMLElement interface: attribute onanimationcancel]
expected: FAIL
[Window interface: attribute onanimationiteration]
expected: FAIL
[CSSKeyframeRule interface: keyframes.cssRules[0\] must inherit property "keyText" with the proper type]
expected: FAIL

View file

@ -1,9 +1,7 @@
[webkit-animation-iteration-event.html]
expected: TIMEOUT
[webkitAnimationIteration event listener is case sensitive]
expected: FAIL
[dispatchEvent of a webkitAnimationIteration event does not trigger an unprefixed event handler or listener]
expected: FAIL
expected: NOTRUN
[onwebkitanimationiteration event handler should trigger for an animation]
expected: FAIL
@ -12,10 +10,10 @@
expected: FAIL
[webkitAnimationIteration event listener should trigger for an animation]
expected: FAIL
expected: TIMEOUT
[webkitAnimationIteration event listener should not trigger if an unprefixed listener also exists]
expected: FAIL
expected: NOTRUN
[onwebkitanimationiteration event handler should not trigger if an unprefixed event handler also exists]
expected: FAIL
@ -24,10 +22,10 @@
expected: FAIL
[event types for prefixed and unprefixed animationiteration event listeners should be named appropriately]
expected: FAIL
expected: NOTRUN
[webkitAnimationIteration event listener should not trigger if an unprefixed event handler also exists]
expected: FAIL
expected: NOTRUN
[onanimationiteration and onwebkitanimationiteration are not aliases]
expected: FAIL