From 707b490c0f1d5f09ac481ae903e349dd2ddd97c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fernando=20Jim=C3=A9nez=20Moreno?= Date: Wed, 12 Dec 2018 16:52:37 +0100 Subject: [PATCH] Signal EOS if media request fails --- components/script/dom/htmlmediaelement.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs index 141ad5c86be..15d0090cba7 100644 --- a/components/script/dom/htmlmediaelement.rs +++ b/components/script/dom/htmlmediaelement.rs @@ -1614,12 +1614,16 @@ impl FetchResponseListener for HTMLMediaElementContext { // https://html.spec.whatwg.org/multipage/#media-data-processing-steps-list fn process_response_eof(&mut self, status: Result) { + let elem = self.elem.root(); if self.ignore_response { - // An error was received previously, skip processing the payload. + // An error was received previously, skip processing the payload + // and notify the media backend that we are done pushing data. + if let Err(e) = elem.player.end_of_stream() { + warn!("Could not signal EOS to player {:?}", e); + } return; } - let elem = self.elem.root(); if status.is_ok() { if elem.ready_state.get() == ReadyState::HaveNothing { // Make sure that we don't skip the HaveMetadata and HaveCurrentData