Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-19 13:23:46 +01:00
Code Issues Projects Releases Packages Wiki Activity

embedder: Improve documentation for various places that talk about "available screen size" (#37879)

Browse source 
Testing: Just add comment. It turns out difficult to achieve, see
https://github.com/rust-windowing/winit/issues/2494.
Fixes: Nothing. Provide some guidance to #37878

---------

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Euclid Ye 2025-07-05 00:05:01 +08:00 • committed by GitHub
parent a81ddd5c18
commit 70b0fb840e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/shared/compositing/lib.rs
View file

@ -174,7 +174,8 @@ pub enum CompositorMsg {
GetClientWindowRect(WebViewId, IpcSender<DeviceIndependentIntRect>), GetClientWindowRect(WebViewId, IpcSender<DeviceIndependentIntRect>),
/// Get the size of the screen that the client window inhabits. /// Get the size of the screen that the client window inhabits.
GetScreenSize(WebViewId, IpcSender<DeviceIndependentIntSize>), GetScreenSize(WebViewId, IpcSender<DeviceIndependentIntSize>),
/// Get the available screen size (without toolbars and docks) for the screen /// Get the available screen size, without system interface elements such as menus, docks, and
/// taskbars.
/// the client window inhabits. /// the client window inhabits.
GetAvailableScreenSize(WebViewId, IpcSender<DeviceIndependentIntSize>), GetAvailableScreenSize(WebViewId, IpcSender<DeviceIndependentIntSize>),

2
components/shared/embedder/lib.rs
View file

@ -711,7 +711,7 @@ pub struct ScreenGeometry {
pub size: DeviceIntSize, pub size: DeviceIntSize,
/// The available size of the screen in device pixels. This size is the size /// The available size of the screen in device pixels. This size is the size
/// available for web content on the screen, and should be `size` minus any system /// available for web content on the screen, and should be `size` minus any system
/// toolbars, docks, and interface elements of the browser. This will be converted to /// toolbars, docks, and interface elements. This will be converted to
/// CSS pixels based on the pixel scaling of the `WebView`. /// CSS pixels based on the pixel scaling of the `WebView`.
pub available_size: DeviceIntSize, pub available_size: DeviceIntSize,
/// The offset of the `WebView` in device pixels for the purposes of the `window.screenLeft` /// The offset of the `WebView` in device pixels for the purposes of the `window.screenLeft`

3
ports/servoshell/desktop/headed_window.rs
View file

@ -431,6 +431,9 @@ impl WindowPortsMethods for Window {
); );
let screen_size = self.screen_size.to_f32() * hidpi_factor; let screen_size = self.screen_size.to_f32() * hidpi_factor;
// FIXME: In reality, this should subtract screen space used by the system interface
// elements, but it is difficult to get this value with `winit` currently. See:
// See https://github.com/rust-windowing/winit/issues/2494
let available_screen_size = screen_size - toolbar_size; let available_screen_size = screen_size - toolbar_size;
// Offset the WebView origin by the toolbar so that it reflects the actual viewport and // Offset the WebView origin by the toolbar so that it reflects the actual viewport and