Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

updated Blob constructor to use optional, fixes https://github.com/servo/servo/issues/10779

Browse source
This commit is contained in:
Yoav Alon 2016-04-21 22:26:08 +03:00
parent 98ae238adf
commit 711c23ae39
3 changed files with 21 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/script/dom/blob.rs
View file

@ -117,19 +117,16 @@ impl Blob {
} }
// https://w3c.github.io/FileAPI/#constructorBlob // https://w3c.github.io/FileAPI/#constructorBlob
pub fn Constructor(global: GlobalRef) -> Fallible<Root<Blob>> { pub fn Constructor(global: GlobalRef,
Ok(Blob::new(global, Vec::new(), "")) blobParts: Option<Vec<BlobOrString>>,
}
// https://w3c.github.io/FileAPI/#constructorBlob
pub fn Constructor_(global: GlobalRef,
blobParts: Vec<BlobOrString>,
blobPropertyBag: &BlobBinding::BlobPropertyBag) blobPropertyBag: &BlobBinding::BlobPropertyBag)
-> Fallible<Root<Blob>> { -> Fallible<Root<Blob>> {
// TODO: accept other blobParts types - ArrayBuffer or ArrayBufferView // TODO: accept other blobParts types - ArrayBuffer or ArrayBufferView
let bytes: Vec<u8> = blobParts.iter() let bytes: Vec<u8> = match blobParts {
.flat_map(|bPart| { None => Vec::new(),
Some(blobs) => {
blobs.iter().flat_map(|bPart| {
match bPart { match bPart {
&BlobOrString::String(ref s) => { &BlobOrString::String(ref s) => {
UTF_8.encode(s, EncoderTrap::Replace).unwrap() UTF_8.encode(s, EncoderTrap::Replace).unwrap()
@ -139,7 +136,9 @@ impl Blob {
}, },
} }
}) })
.collect(); .collect()
}
};
let typeString = if is_ascii_printable(&blobPropertyBag.type_) { let typeString = if is_ascii_printable(&blobPropertyBag.type_) {
&*blobPropertyBag.type_ &*blobPropertyBag.type_
} else { } else {

3
components/script/dom/webidls/Blob.webidl
View file

@ -4,8 +4,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob // http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
[Constructor, [Constructor(optional sequence<(/*ArrayBuffer or ArrayBufferView or */Blob or DOMString)> blobParts,
Constructor(sequence<(/*ArrayBuffer or ArrayBufferView or */Blob or DOMString)> blobParts,
optional BlobPropertyBag options), optional BlobPropertyBag options),
Exposed=Window/*,Worker*/] Exposed=Window/*,Worker*/]
interface Blob { interface Blob {

4
tests/wpt/metadata/FileAPI/blob/Blob-constructor.html.ini
View file

@ -46,7 +46,3 @@
bug: https://github.com/servo/servo/issues/10744 bug: https://github.com/servo/servo/issues/10744
expected: FAIL expected: FAIL
[Blob constructor with undefined as first argument]
bug: https://github.com/servo/servo/issues/10779
expected: FAIL