Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

tools: Improve instrumentation and add it for some layout (#33647)

Browse source 
Improves the instrumentation to skip all function arguments and also add
spans for some layout modes. This is preparation for improving the
performance of flexbox.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2024-10-05 10:55:40 +02:00 • committed by GitHub
parent 20eb927843
commit 719b5aba24
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 140 additions and 115 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/fonts/system_font_service.rs
View file

@ -25,7 +25,7 @@ use style::values::computed::font::{
use style::values::computed::{FontStretch, FontWeight};
use style::values::specified::FontStretch as SpecifiedFontStretch;
use style::Atom;
use tracing::{span, Level};
use tracing::{instrument, span, Level};
use webrender_api::{FontInstanceFlags, FontInstanceKey, FontKey};
use webrender_traits::WebRenderFontApi;
@ -156,7 +156,7 @@ impl SystemFontService {
SystemFontServiceProxySender(sender)
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn run(&mut self) {
loop {
let msg = self.port.recv().unwrap();
@ -196,7 +196,7 @@ impl SystemFontService {
}
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn fetch_new_keys(&mut self) {
if !self.free_font_keys.is_empty() && !self.free_font_instance_keys.is_empty() {
return;
@ -213,7 +213,7 @@ impl SystemFontService {
.append(&mut new_font_instance_keys);
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn get_font_templates(
&mut self,
font_descriptor: Option<FontDescriptor>,
@ -246,7 +246,7 @@ impl SystemFontService {
}
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn refresh_local_families(&mut self) {
self.local_families.clear();
for_each_available_family(|family_name| {
@ -257,7 +257,7 @@ impl SystemFontService {
});
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn find_font_templates(
&mut self,
descriptor_to_match: Option<&FontDescriptor>,
@ -281,7 +281,7 @@ impl SystemFontService {
.unwrap_or_default()
}
#[tracing::instrument(skip(self), fields(servo_profiling = true))]
#[instrument(skip_all, fields(servo_profiling = true))]
fn get_font_instance(
&mut self,
identifier: FontIdentifier,