Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Reduce IPC for viewport boundary check (#38113)

Browse source 
Testing: No behaviour change.

---------

Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
Euclid Ye 2025-07-16 18:06:49 +08:00 • committed by GitHub
parent 7dae7f9983
commit 72a9f36c43
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/webdriver_server/actions.rs
View file

@ -788,7 +788,13 @@ impl Handler {
);
}
/// Verify that the given coordinates are within the boundary of the viewport.
/// If x or y is less than 0 or greater than the width of the viewport in CSS pixels,
/// then return error with error code move target out of bounds.
fn check_viewport_bound(&self, x: f64, y: f64) -> Result<(), ErrorStatus> {
if x < 0.0 || y < 0.0 {
return Err(ErrorStatus::MoveTargetOutOfBounds);
}
let (sender, receiver) = ipc::channel().unwrap();
let cmd_msg =
WebDriverCommandMsg::GetViewportSize(self.session.as_ref().unwrap().webview_id, sender);
@ -799,7 +805,7 @@ impl Handler {
Ok(response) => response,
Err(WebDriverError { error, .. }) => return Err(error),
};
if x < 0.0 || x > viewport_size.width.into() || y < 0.0 || y > viewport_size.height.into() {
if x > viewport_size.width.into() || y > viewport_size.height.into() {
Err(ErrorStatus::MoveTargetOutOfBounds)
} else {
Ok(())