mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
Remove BoxFragment::overconstrained (#33907)
This was only used for serializing inset properties in getComputedStyle, but it was unnecessary and the logic was wrong anyways: an `auto` size doesn't imply that we won't be overconstrained, because it won't become negative even if the insets are big enough. Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau
GitHub
parent
09fc988d3a
commit
73880ee1d0
4 changed files with 16 additions and 287 deletions
|
|
@ -2,48 +2,21 @@
|
|||
[vertical-lr ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -53,36 +26,18 @@
|
|||
[vertical-rl ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -92,57 +47,27 @@
|
|||
[horizontal-tb rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -152,65 +77,32 @@
|
|||
[vertical-lr rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
|
|
|||
|
|
@ -2,48 +2,21 @@
|
|||
[vertical-lr ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -53,36 +26,18 @@
|
|||
[vertical-rl ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -92,57 +47,27 @@
|
|||
[horizontal-tb rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
|
|
@ -152,65 +77,32 @@
|
|||
[vertical-lr rtl inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside horizontal-tb ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl ltr inside vertical-lr ltr - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-lr rtl inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside vertical-lr ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-lr rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[vertical-rl rtl inside vertical-rl rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl rtl - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb rtl inside horizontal-tb rtl - If opposite sides are 'auto', they resolve to used value]
|
||||
expected: FAIL
|
||||
|
||||
[horizontal-tb ltr inside vertical-rl ltr - Percentages absolutize the computed value when overconstrained]
|
||||
expected: FAIL
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue