Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 08:55:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

opts.rs: don't accept multiple URLs. Fixes #5520.

Browse source 
Switched from opts.urls from being of type Vec to type String and changing the name to `url` as well. Changed the other files that are using opts.urls accordingly.

servo/lib.rs + gonk/src/lib.rs: no need for a block scope.

cef: fix compiler errors.

- remove the use of `mut` since it's not needed.
- use `to_owned` instead of `to_string` because it's more efficient.
This commit is contained in:
Jag Talon 2015-04-04 18:00:00 -04:00
parent c070ad6196
commit 74cd4cd56a
5 changed files with 28 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

6
ports/cef/browser.rs
View file

@ -204,10 +204,9 @@ fn browser_host_create(window_info: &cef_window_info_t,
client: CefClient,
callback_executed: bool)
-> CefBrowser {
let mut urls = Vec::new();
urls.push("http://s27.postimg.org/vqbtrolyr/servo.jpg".to_owned());
let url = "http://s27.postimg.org/vqbtrolyr/servo.jpg".to_owned();
let mut opts = opts::default_opts();
opts.urls = urls;
opts.url = url;
let browser = ServoCefBrowser::new(window_info, client).as_cef_interface();
browser.init(window_info);
if callback_executed {
@ -246,4 +245,3 @@ cef_static_method_impls! {
browser_host_create(window_info, client, true)
}}
}

3
ports/cef/core.rs
View file

@ -70,7 +70,7 @@ pub extern "C" fn cef_initialize(args: *const cef_main_args_t,
};
let mut temp_opts = opts::default_opts();
temp_opts.urls = vec![HOME_URL.to_owned()];
temp_opts.url = HOME_URL.to_owned();
temp_opts.paint_threads = rendering_threads;
temp_opts.layout_threads = rendering_threads;
temp_opts.headless = false;
@ -137,4 +137,3 @@ pub extern "C" fn cef_log(_file: *const c_char,
pub extern "C" fn cef_get_min_log_level() -> c_int {
0
}

21
ports/gonk/src/lib.rs
View file

@ -113,23 +113,20 @@ impl Browser {
// Send the URL command to the constellation.
let cwd = env::current_dir().unwrap();
for url in opts.urls.iter() {
let url = match url::Url::parse(&*url) {
Ok(url) => url,
Err(url::ParseError::RelativeUrlWithoutBase)
=> url::Url::from_file_path(&*cwd.join(&*url)).unwrap(),
Err(_) => panic!("URL parsing failed"),
};
let url = match url::Url::parse(&opts.url) {
Ok(url) => url,
Err(url::ParseError::RelativeUrlWithoutBase)
=> url::Url::from_file_path(&*cwd.join(&opts.url)).unwrap(),
Err(_) => panic!("URL parsing failed"),
};
let ConstellationChan(ref chan) = constellation_chan;
chan.send(ConstellationMsg::InitLoadUrl(url)).unwrap();
}
let ConstellationChan(ref chan) = constellation_chan;
chan.send(ConstellationMsg::InitLoadUrl(url)).unwrap();
debug!("preparing to enter main loop");
let compositor = CompositorTask::create(window,
compositor_proxy,
compositor_receiver,
constellation_chan,
constellation_chan.clone(),
time_profiler_chan,
mem_profiler_chan);