Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Allow the <details> element to be opened and closed (#35261)

Browse source 
* Implement the <summary> element

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Implement UA shadow root for <details>

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Invalidate style when display is opened or closed

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Fix /_mozilla/mozilla/duplicated_scroll_ids.html

This test previously assumed that <details> elements would
not be rendered.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Implement implicit summary elements

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Remove test for duplicated scroll IDs

See https://github.com/servo/servo/pull/35261#discussion_r1969328725 for
reasoning.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Use Iterator::find to find implicit summary element

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-02-25 12:56:36 +01:00 • committed by GitHub
parent cceff77928
commit 754b117011
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 251 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/selectors/selectors-4/details-open-pseudo-003.html.ini vendored
View file

@ -1,2 +0,0 @@
[details-open-pseudo-003.html]
expected: FAIL

3
tests/wpt/meta/html/dom/elements/the-innertext-and-outertext-properties/getter.html.ini vendored
View file

@ -25,3 +25,6 @@
[::first-line styles applied ("<div class='first-line-uppercase'>abc")]
expected: FAIL
[opened <details> content shown ("<div><details open><summary>abc</summary>123")]
expected: FAIL

3
tests/wpt/meta/html/rendering/the-details-element/details-display.html.ini vendored
View file

@ -1,6 +1,3 @@
[details-display.html]
[default display of first summary child of details is list-item]
expected: FAIL
[display of details element can be changed]
expected: FAIL

2
tests/wpt/meta/html/rendering/the-details-element/details-revert.html.ini vendored
View file

@ -1,2 +0,0 @@
[details-revert.html]
expected: FAIL

2
tests/wpt/meta/html/rendering/the-details-element/details-summary-display-inline-001.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[details-summary-display-inline-001.html]
expected: FAIL

2
tests/wpt/meta/html/rendering/the-details-element/details-summary-display-inline-002.html.ini vendored
View file

@ -1,2 +0,0 @@
[details-summary-display-inline-002.html]
expected: FAIL

2
tests/wpt/meta/html/rendering/the-details-element/summary-display-list-item-001.html.ini vendored
View file

@ -1,2 +0,0 @@
[summary-display-list-item-001.html]
expected: FAIL

2
tests/wpt/meta/html/rendering/the-details-element/summary-text-decoration.html.ini vendored
View file

@ -1,2 +0,0 @@
[summary-text-decoration.html]
expected: FAIL

3
tests/wpt/meta/html/semantics/interactive-elements/the-details-element/closed-details-layout-apis.tentative.html.ini vendored Normal file
View file

@ -0,0 +1,3 @@
[closed-details-layout-apis.tentative.html]
[Verifies the layout results of elements inside a closed <details> based on the usage of content-visibility:hidden.]
expected: FAIL

2
tests/wpt/meta/html/semantics/interactive-elements/the-details-element/details-add-summary.html.ini vendored
View file

@ -1,2 +0,0 @@
[details-add-summary.html]
expected: FAIL

17
tests/wpt/mozilla/meta/MANIFEST.json vendored
View file

@ -7581,19 +7581,6 @@
{}
]
],
"duplicated_scroll_ids.html": [
"a0ac8e578ddb63efa9aa673285a38c67c4ba6c2b",
[
null,
[
[
"/_mozilla/mozilla/duplicated_scroll_ids_ref.html",
"=="
]
],
{}
]
],
"font-element-comma-separated.html": [
"db7e13f2ca3db0ebd3c610c3c25b052749b85e30",
[
@ -10463,10 +10450,6 @@
"3e68ff395f5475e2b618147f270117f576a5b7bd",
[]
],
"duplicated_scroll_ids_ref.html": [
"6783d72a6629f4938df8126dc5114d936eaaa48f",
[]
],
"font-element-comma-separated-ref.html": [
"97efe2b83d5f78bdac0d4aa951b63342fb1fa1cf",
[]

13
tests/wpt/mozilla/tests/mozilla/duplicated_scroll_ids.html vendored
View file

@ -1,13 +0,0 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<link rel="match" href="duplicated_scroll_ids_ref.html">
<title>Ensure that content which produces duplicate scroll ids does not panic</title>
</head>
<body>
<div style="width: 100px; height: 100px; background: green"></div>
<details open style="overflow: auto">
</body>
</html>

11
tests/wpt/mozilla/tests/mozilla/duplicated_scroll_ids_ref.html vendored
View file

@ -1,11 +0,0 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Ensure that content which produces duplicate scroll ids does not panic</title>
</head>
<body>
<div style="width: 100px; height: 100px; background: green"></div>
</body>
</html>