Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-01 00:59:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Pass S3 secrets for nightly builds and fix windows build

Browse source 
Secrets need to be passed to reusable workflows either
by name or by `secrets: inherit` from the caller workflow.
The latter allows accessing all secrets in scope.

Windows build has a bug where the upload-nightly command is
not run from the correct working directory.

Closes #29614

Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
This commit is contained in:
Mukilan Thiyagarajan 2023-04-11 14:02:41 +05:30
parent aad3ad9102
commit 757666fd4b
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/nightly.yml vendored
View file

@ -19,6 +19,7 @@ jobs:
with:
layout: '2013'
upload: true
secrets: inherit
upload-mac:
# This job is only useful when run on upstream servo.
@ -28,6 +29,7 @@ jobs:
with:
layout: '2013'
upload: true
secrets: inherit
upload-linux:
# This job is only useful when run on upstream servo.
@ -37,6 +39,7 @@ jobs:
with:
layout: '2013'
upload: true
secrets: inherit
upload-linux-2020:
# This job is only useful when run on upstream servo.
@ -46,3 +49,4 @@ jobs:
with:
layout: '2020'
upload: true
secrets: inherit