From 75b38efefd101441ac1f2a84f54acbe6ca4c39d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Tue, 30 Jun 2020 22:31:22 +0000 Subject: [PATCH] style: Have the destructor of CalcNode be never inline. You tell me which other things need it... Copy-constructor? operator==? and such? Differential Revision: https://phabricator.services.mozilla.com/D73385 --- components/style/values/generics/calc.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/components/style/values/generics/calc.rs b/components/style/values/generics/calc.rs index cd331818386..0d791e5d00d 100644 --- a/components/style/values/generics/calc.rs +++ b/components/style/values/generics/calc.rs @@ -60,6 +60,13 @@ pub enum SortKey { /// /// FIXME: This would be much more elegant if we used `Self` in the types below, /// but we can't because of https://github.com/serde-rs/serde/issues/1565. +/// +/// FIXME: The following annotations are to workaround an LLVM inlining bug, see +/// bug 1631929. +/// +/// cbindgen:destructor-attributes=MOZ_NEVER_INLINE +/// cbindgen:copy-constructor-attributes=MOZ_NEVER_INLINE +/// cbindgen:eq-attributes=MOZ_NEVER_INLINE #[repr(u8)] #[derive( Clone,