Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make createRadialGradient throw for negative radii

Browse source
This commit is contained in:
David Zbarsky 2015-08-04 15:05:15 -04:00
parent 0565df8596
commit 75e444c3b2
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/canvasrenderingcontext2d.rs
View file

@ -1019,10 +1019,14 @@ impl<'a> CanvasRenderingContext2DMethods for &'a CanvasRenderingContext2D {
// https://html.spec.whatwg.org/multipage/#dom-context-2d-createradialgradient // https://html.spec.whatwg.org/multipage/#dom-context-2d-createradialgradient
fn CreateRadialGradient(self, x0: Finite<f64>, y0: Finite<f64>, r0: Finite<f64>, fn CreateRadialGradient(self, x0: Finite<f64>, y0: Finite<f64>, r0: Finite<f64>,
x1: Finite<f64>, y1: Finite<f64>, r1: Finite<f64>) x1: Finite<f64>, y1: Finite<f64>, r1: Finite<f64>)
-> Root<CanvasGradient> { -> Fallible<Root<CanvasGradient>> {
CanvasGradient::new(self.global.root().r(), if *r0 < 0. || *r1 < 0. {
return Err(IndexSize);
}
Ok(CanvasGradient::new(self.global.root().r(),
CanvasGradientStyle::Radial( CanvasGradientStyle::Radial(
RadialGradientStyle::new(*x0, *y0, *r0, *x1, *y1, *r1, Vec::new()))) RadialGradientStyle::new(*x0, *y0, *r0, *x1, *y1, *r1, Vec::new()))))
} }
// https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern // https://html.spec.whatwg.org/multipage/#dom-context-2d-createpattern

1
components/script/dom/webidls/CanvasRenderingContext2D.webidl
View file

@ -59,6 +59,7 @@ interface CanvasRenderingContext2D {
attribute (DOMString or CanvasGradient or CanvasPattern) strokeStyle; // (default black) attribute (DOMString or CanvasGradient or CanvasPattern) strokeStyle; // (default black)
attribute (DOMString or CanvasGradient or CanvasPattern) fillStyle; // (default black) attribute (DOMString or CanvasGradient or CanvasPattern) fillStyle; // (default black)
CanvasGradient createLinearGradient(double x0, double y0, double x1, double y1); CanvasGradient createLinearGradient(double x0, double y0, double x1, double y1);
[Throws]
CanvasGradient createRadialGradient(double x0, double y0, double r0, double x1, double y1, double r1); CanvasGradient createRadialGradient(double x0, double y0, double r0, double x1, double y1, double r1);
[Throws] [Throws]
CanvasPattern createPattern(CanvasImageSource image, [TreatNullAs=EmptyString] DOMString repetition); CanvasPattern createPattern(CanvasImageSource image, [TreatNullAs=EmptyString] DOMString repetition);

5
tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.gradient.radial.negative.html.ini
View file

@ -1,5 +0,0 @@
[2d.gradient.radial.negative.html]
type: testharness
[createRadialGradient() throws INDEX_SIZE_ERR if either radius is negative]
expected: FAIL