Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implemented Location.assign

Browse source
This commit is contained in:
Keith Yeung 2015-02-06 09:25:59 +08:00
parent c360b75e16
commit 75e5c6fcdb
3 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/location.rs
View file

@ -9,6 +9,7 @@ use dom::bindings::js::{JSRef, Temporary};
use dom::bindings::utils::{Reflector, reflect_dom_object}; use dom::bindings::utils::{Reflector, reflect_dom_object};
use dom::urlhelper::UrlHelper; use dom::urlhelper::UrlHelper;
use dom::window::Window; use dom::window::Window;
use dom::window::WindowHelpers;
use page::Page; use page::Page;
use util::str::DOMString; use util::str::DOMString;
@ -37,6 +38,11 @@ impl Location {
} }
impl<'a> LocationMethods for JSRef<'a, Location> { impl<'a> LocationMethods for JSRef<'a, Location> {
// https://html.spec.whatwg.org/multipage/browsers.html#dom-location-assign
fn Assign(self, url: DOMString) {
self.page.frame().as_ref().unwrap().window.root().r().load_url(url);
}
fn Href(self) -> DOMString { fn Href(self) -> DOMString {
UrlHelper::Href(&self.page.get_url()) UrlHelper::Href(&self.page.get_url())
} }

2
components/script/dom/webidls/Location.webidl
View file

@ -5,7 +5,7 @@
// http://www.whatwg.org/html/#location // http://www.whatwg.org/html/#location
/*[Unforgeable]*/ interface Location { /*[Unforgeable]*/ interface Location {
//void assign(DOMString url); void assign(DOMString url);
//void replace(DOMString url); //void replace(DOMString url);
//void reload(); //void reload();
}; };

9
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -8646,21 +8646,12 @@
[Location interface object length] [Location interface object length]
expected: FAIL expected: FAIL
[Location interface: operation assign(DOMString)]
expected: FAIL
[Location interface: operation replace(DOMString)] [Location interface: operation replace(DOMString)]
expected: FAIL expected: FAIL
[Location interface: operation reload()] [Location interface: operation reload()]
expected: FAIL expected: FAIL
[Location interface: window.location must inherit property "assign" with the proper type (0)]
expected: FAIL
[Location interface: calling assign(DOMString) on window.location with too few arguments must throw TypeError]
expected: FAIL
[Location interface: window.location must inherit property "replace" with the proper type (1)] [Location interface: window.location must inherit property "replace" with the proper type (1)]
expected: FAIL expected: FAIL