Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-23 08:34:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #29631 - mrobinson:correct-positioned-block-axis-calculation, r=mrego

Browse source 
Fix calculation of block axis for abspos elements in Layout 2020

The calculation of the block axis positioning of absolutely positioned elements was using the inline size of the containing block instead of the block size.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2023-04-14 16:33:49 +02:00 • committed by GitHub
commit 766917ef4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 3 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/layout_2020/positioned.rs
View file

@ -458,8 +458,7 @@ impl HoistedAbsolutelyPositionedBox {
};
let solve_block_axis = |computed_size| {
solve_axis(
// TODO(delan) shouldn’t this be cbbs?
cbis,
cbbs,
pbm.padding_border_sums.block,
pbm.margin.block_start,
pbm.margin.block_end,

2
tests/wpt/metadata-layout-2020/css/CSS2/backgrounds/background-position-152.xht.ini
View file

@ -1,2 +0,0 @@
[background-position-152.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/normal-flow/height-percentage-003.xht.ini
View file

@ -1,2 +0,0 @@
[height-percentage-003.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/positioning/bottom-offset-percentage-001.xht.ini
View file

@ -1,2 +0,0 @@
[bottom-offset-percentage-001.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/positioning/left-offset-percentage-002.xht.ini
View file

@ -1,2 +0,0 @@
[left-offset-percentage-002.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/positioning/top-offset-percentage-001.xht.ini
View file

@ -1,2 +0,0 @@
[top-offset-percentage-001.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/positioning/top-offset-percentage-002.xht.ini
View file

@ -1,2 +0,0 @@
[top-offset-percentage-002.xht]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/CSS2/visuren/position-absolute-percentage-inherit-001.xht.ini
View file

@ -1,2 +0,0 @@
[position-absolute-percentage-inherit-001.xht]
expected: FAIL

12
tests/wpt/metadata-layout-2020/css/css-position/position-absolute-dynamic-containing-block.html.ini
View file

@ -1,16 +1,4 @@
[position-absolute-dynamic-containing-block.html]
[abs containing block moves from outer to intermediate]
expected: FAIL
[abs containing block moves from intermediate to outer]
expected: FAIL
[target is no longer absolute]
expected: FAIL
[target becomes absolute]
expected: FAIL
[fixed containing block moves from outer to intermediate]
expected: FAIL

2
tests/wpt/metadata-layout-2020/css/css-position/position-absolute-fit-content.html.ini Normal file
View file

@ -0,0 +1,2 @@
[position-absolute-fit-content.html]
expected: FAIL