Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Improve documentations for actions.rs and update TODOs (#39391)

Browse source 
Add specification quote for each steps, remove some irrelevant TODO, and
move function position closer to related function.

Testing: No behaviour change

---------

Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Kenzie Raditya Tirtarahardja 2025-09-21 13:42:16 +08:00 • committed by GitHub
parent 2c8533f38e
commit 77ae3a0eb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 166 additions and 134 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/webdriver_server/lib.rs
View file

@ -2134,17 +2134,12 @@ impl Handler {
);
self.browsing_context_script_command(cmd, VerifyBrowsingContextIsOpen::No)?;
// TODO: distinguish the not found and not focusable cases
// File input and non-typeable form control should have
// been handled in `webdriver_handler.rs`.
if !wait_for_ipc_response(receiver)?.map_err(|error| WebDriverError::new(error, ""))? {
return Ok(WebDriverResponse::Void);
}
// TODO: there's a race condition caused by the focus command and the
// send keys command being two separate messages,
// so the constellation may have changed state between them.
// Step 10. Let input id be a the result of generating a UUID.
let id = Uuid::new_v4().to_string();