mirror of
https://github.com/servo/servo.git
synced 2025-07-22 06:43:40 +01:00
script: Eliminate code duplication in the task queue (#34798)
Instead of creating a type for each `TaskSource` variety have each `TaskSource` hold the same kind of sender (this was inconsistent before, but each sender was effectively the same trait object), a pipeline, and a `TaskSourceName`. This elminates the need to reimplement the same queuing code for every task source. In addition, have workers hold their own `TaskManager`. This allows just exposing the manager on the `GlobalScope`. Currently the `TaskCanceller` is different, but this will also be eliminated in a followup change. This is a the first step toward having a shared set of `Sender`s on `GlobalScope`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
parent
deb819f233
commit
77cfca65c4
67 changed files with 432 additions and 1200 deletions
|
@ -67,7 +67,6 @@ use crate::script_module::{
|
|||
};
|
||||
use crate::script_runtime::CanGc;
|
||||
use crate::task::TaskCanceller;
|
||||
use crate::task_source::dom_manipulation::DOMManipulationTaskSource;
|
||||
use crate::task_source::{TaskSource, TaskSourceName};
|
||||
use crate::unminify::{unminify_js, ScriptSource};
|
||||
|
||||
|
@ -104,7 +103,7 @@ impl ScriptSource for ScriptOrigin {
|
|||
script_kind: ExternalScriptKind,
|
||||
final_url: ServoUrl,
|
||||
url: ServoUrl,
|
||||
task_source: DOMManipulationTaskSource,
|
||||
task_source: TaskSource,
|
||||
canceller: TaskCanceller,
|
||||
script_text: String,
|
||||
fetch_options: ScriptFetchOptions,
|
||||
|
@ -478,7 +477,7 @@ impl FetchResponseListener for ClassicContext {
|
|||
script_kind: self.kind,
|
||||
final_url,
|
||||
url: self.url.clone(),
|
||||
task_source: global.dom_manipulation_task_source(),
|
||||
task_source: global.task_manager().dom_manipulation_task_source(),
|
||||
canceller: global.task_canceller(TaskSourceName::DOMManipulation),
|
||||
script_text: source_string,
|
||||
fetch_options: self.fetch_options.clone(),
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue