mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
script: Eliminate code duplication in the task queue (#34798)
Instead of creating a type for each `TaskSource` variety have each `TaskSource` hold the same kind of sender (this was inconsistent before, but each sender was effectively the same trait object), a pipeline, and a `TaskSourceName`. This elminates the need to reimplement the same queuing code for every task source. In addition, have workers hold their own `TaskManager`. This allows just exposing the manager on the `GlobalScope`. Currently the `TaskCanceller` is different, but this will also be eliminated in a followup change. This is a the first step toward having a shared set of `Sender`s on `GlobalScope`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
parent
deb819f233
commit
77cfca65c4
67 changed files with 432 additions and 1200 deletions
|
@ -54,7 +54,6 @@ use crate::dom::workerglobalscope::WorkerGlobalScope;
|
|||
use crate::realms::InRealm;
|
||||
use crate::script_runtime::{CanGc, JSContext};
|
||||
use crate::task::TaskCanceller;
|
||||
use crate::task_source::dom_manipulation::DOMManipulationTaskSource;
|
||||
use crate::task_source::TaskSource;
|
||||
|
||||
// String constants for algorithms/curves
|
||||
|
@ -142,13 +141,13 @@ impl SubtleCrypto {
|
|||
)
|
||||
}
|
||||
|
||||
fn task_source_with_canceller(&self) -> (DOMManipulationTaskSource, TaskCanceller) {
|
||||
fn task_source_with_canceller(&self) -> (TaskSource, TaskCanceller) {
|
||||
if let Some(window) = self.global().downcast::<Window>() {
|
||||
window
|
||||
.task_manager()
|
||||
.dom_manipulation_task_source_with_canceller()
|
||||
} else if let Some(worker_global) = self.global().downcast::<WorkerGlobalScope>() {
|
||||
let task_source = worker_global.dom_manipulation_task_source();
|
||||
let task_source = worker_global.task_manager().dom_manipulation_task_source();
|
||||
let canceller = worker_global.task_canceller();
|
||||
(task_source, canceller)
|
||||
} else {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue