Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Return null when an attr's namespace is not set

Browse source
This commit is contained in:
Connor Brewster 2017-07-17 23:07:23 -06:00
parent 2460997ee1
commit 77efab8a9e
10 changed files with 6 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/script/dom/customelementregistry.rs
View file

@ -600,9 +600,11 @@ impl CustomElementReactionStack {
unsafe { val.to_jsval(cx, value.handle_mut()); } unsafe { val.to_jsval(cx, value.handle_mut()); }
} }
rooted!(in(cx) let mut namespace_value = NullValue());
if namespace != ns!() {
let namespace = DOMString::from(&*namespace); let namespace = DOMString::from(&*namespace);
rooted!(in(cx) let mut namespace_value = UndefinedValue());
unsafe { namespace.to_jsval(cx, namespace_value.handle_mut()); } unsafe { namespace.to_jsval(cx, namespace_value.handle_mut()); }
}
let args = vec![Heap::default(), Heap::default(), Heap::default(), Heap::default()]; let args = vec![Heap::default(), Heap::default(), Heap::default(), Heap::default()];
args[0].set(name_value.get()); args[0].set(name_value.get());

23
tests/wpt/metadata/custom-elements/attribute-changed-callback.html.ini
View file

@ -1,26 +1,5 @@
[attribute-changed-callback.html] [attribute-changed-callback.html]
type: testharness type: testharness
[setAttribute and removeAttribute must enqueue and invoke attributeChangedCallback] [Custom Elements: attributeChangedCallback]
expected: FAIL
[setAttributeNode and removeAttributeNode must enqueue and invoke attributeChangedCallback for an HTML attribute]
expected: FAIL
[Mutating attributeChangedCallback after calling customElements.define must not affect the callback being invoked]
expected: FAIL
[attributedChangedCallback must not be invoked when the observed attributes does not contain the attribute]
expected: FAIL
[Mutating observedAttributes after calling customElements.define must not affect the set of attributes for which attributedChangedCallback is invoked]
expected: FAIL
[attributedChangedCallback must be enqueued for attributes specified in a non-Array iterable observedAttributes]
expected: FAIL
[attributedChangedCallback must be enqueued for style attribute change by mutating inline style declaration]
expected: FAIL
[attributedChangedCallback must not be enqueued when mutating inline style declaration if the style attribute is not observed]
expected: FAIL expected: FAIL

5
tests/wpt/metadata/custom-elements/reactions/Attr.html.ini
View file

@ -1,5 +0,0 @@
[Attr.html]
type: testharness
[value on Attr must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL

42
tests/wpt/metadata/custom-elements/reactions/CSSStyleDeclaration.html.ini
View file

@ -1,47 +1,5 @@
[CSSStyleDeclaration.html] [CSSStyleDeclaration.html]
type: testharness type: testharness
[cssText on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[cssText on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute]
expected: FAIL
[setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute]
expected: FAIL
[setProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important and the style attribute is observed]
expected: FAIL
[setPropertyValue on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[setPropertyValue on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute]
expected: FAIL
[setPropertyPriority on CSSStyleDeclaration must enqueue an attributeChanged reaction when it makes a property important and the style attribute is observed]
expected: FAIL
[removeProperty on CSSStyleDeclaration must enqueue an attributeChanged reaction when it removes a property from the observed style attribute]
expected: FAIL
[cssFloat on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[A camel case attribute (borderWidth) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[A camel case attribute (borderWidth) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute]
expected: FAIL
[A dashed property (border-width) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL
[A dashed property (border-width) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it mutates the observed style attribute]
expected: FAIL
[A webkit prefixed camel case attribute (webkitFilter) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute] [A webkit prefixed camel case attribute (webkitFilter) on CSSStyleDeclaration must enqueue an attributeChanged reaction when it adds the observed style attribute]
expected: FAIL expected: FAIL

14
tests/wpt/metadata/custom-elements/reactions/DOMStringMap.html.ini
View file

@ -1,14 +0,0 @@
[DOMStringMap.html]
type: testharness
[setter on DOMStringMap must enqueue an attributeChanged reaction when adding an observed data attribute]
expected: FAIL
[setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute]
expected: FAIL
[setter on DOMStringMap must enqueue an attributeChanged reaction when mutating the value of an observed data attribute to the same value]
expected: FAIL
[deleter on DOMStringMap must enqueue an attributeChanged reaction when removing an observed data attribute]
expected: FAIL

36
tests/wpt/metadata/custom-elements/reactions/DOMTokenList.html.ini
View file

@ -1,41 +1,5 @@
[DOMTokenList.html] [DOMTokenList.html]
type: testharness type: testharness
[add on DOMTokenList must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[add on DOMTokenList must enqueue an attributeChanged reaction when adding a value to an existing attribute]
expected: FAIL
[add on DOMTokenList must enqueue exactly one attributeChanged reaction when adding multiple values to an attribute]
expected: FAIL
[remove on DOMTokenList must enqueue an attributeChanged reaction when removing a value from an attribute]
expected: FAIL
[remove on DOMTokenList must enqueue exactly one attributeChanged reaction when removing multiple values to an attribute]
expected: FAIL
[remove on DOMTokenList must enqueue an attributeChanged reaction even when removing a non-existent value from an attribute]
expected: FAIL
[toggle on DOMTokenList must enqueue an attributeChanged reaction when adding a value to an attribute]
expected: FAIL
[toggle on DOMTokenList must enqueue an attributeChanged reaction when removing a value from an attribute]
expected: FAIL
[replace on DOMTokenList must enqueue an attributeChanged reaction when replacing a value in an attribute]
expected: FAIL
[replace on DOMTokenList must not enqueue an attributeChanged reaction when the token to replace does not exist in the attribute] [replace on DOMTokenList must not enqueue an attributeChanged reaction when the token to replace does not exist in the attribute]
expected: FAIL expected: FAIL
[the stringifier of DOMTokenList must enqueue an attributeChanged reaction when adding an observed attribute]
expected: FAIL
[the stringifier of DOMTokenList must enqueue an attributeChanged reaction when mutating the value of an observed attribute]
expected: FAIL
[the stringifier of DOMTokenList must enqueue an attributeChanged reaction when the setter is called with the original value of the attribute]
expected: FAIL

39
tests/wpt/metadata/custom-elements/reactions/Element.html.ini
View file

@ -1,56 +1,17 @@
[Element.html] [Element.html]
type: testharness type: testharness
[id on Element must enqueue an attributeChanged reaction when adding id content attribute]
expected: FAIL
[id on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[className on Element must enqueue an attributeChanged reaction when adding class content attribute]
expected: FAIL
[className on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[slot on Element must enqueue an attributeChanged reaction when adding slot content attribute] [slot on Element must enqueue an attributeChanged reaction when adding slot content attribute]
expected: FAIL expected: FAIL
[slot on Element must enqueue an attributeChanged reaction when replacing an existing attribute] [slot on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[setAttribute on Element must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setAttribute on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[setAttributeNS on Element must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setAttributeNS on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[removeAttribute on Element must enqueue an attributeChanged reaction when removing an existing attribute]
expected: FAIL
[removeAttributeNS on Element must enqueue an attributeChanged reaction when removing an existing attribute]
expected: FAIL
[setAttributeNode on Element must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setAttributeNode on Element must enqueue an attributeChanged reaction when replacing an existing attribute] [setAttributeNode on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[setAttributeNodeNS on Element must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setAttributeNodeNS on Element must enqueue an attributeChanged reaction when replacing an existing attribute] [setAttributeNodeNS on Element must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[removeAttributeNode on Element must enqueue an attributeChanged reaction when removing an existing attribute]
expected: FAIL
[innerHTML on Element must enqueue a connected reaction for a newly constructed custom element] [innerHTML on Element must enqueue a connected reaction for a newly constructed custom element]
expected: FAIL expected: FAIL

18
tests/wpt/metadata/custom-elements/reactions/HTMLElement.html.ini
View file

@ -1,17 +1,5 @@
[HTMLElement.html] [HTMLElement.html]
type: testharness type: testharness
[title on HTMLElement must enqueue an attributeChanged reaction when adding title content attribute]
expected: FAIL
[title on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[lang on HTMLElement must enqueue an attributeChanged reaction when adding lang content attribute]
expected: FAIL
[lang on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute] [translate on HTMLElement must enqueue an attributeChanged reaction when adding translate content attribute]
expected: FAIL expected: FAIL
@ -24,12 +12,6 @@
[dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute] [dir on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[hidden on HTMLElement must enqueue an attributeChanged reaction when adding hidden content attribute]
expected: FAIL
[hidden on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute] [tabIndex on HTMLElement must enqueue an attributeChanged reaction when adding tabindex content attribute]
expected: FAIL expected: FAIL

12
tests/wpt/metadata/custom-elements/reactions/NamedNodeMap.html.ini
View file

@ -1,20 +1,8 @@
[NamedNodeMap.html] [NamedNodeMap.html]
type: testharness type: testharness
[setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute] [setNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when adding an attribute]
expected: FAIL
[setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute] [setNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL expected: FAIL
[removeNamedItem on NamedNodeMap must enqueue an attributeChanged reaction when removing an existing attribute]
expected: FAIL
[removeNamedItemNS on NamedNodeMap must enqueue an attributeChanged reaction when removing an existing attribute]
expected: FAIL

6
tests/wpt/metadata/custom-elements/reactions/Node.html.ini
View file

@ -1,11 +1,5 @@
[Node.html] [Node.html]
type: testharness type: testharness
[nodeValue on Node must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[textContent on Node must enqueue an attributeChanged reaction when replacing an existing attribute]
expected: FAIL
[cloneNode on Node must enqueue an attributeChanged reaction when cloning an element with an observed attribute] [cloneNode on Node must enqueue an attributeChanged reaction when cloning an element with an observed attribute]
expected: FAIL expected: FAIL