Refactored tidy for efficiency and optionally provide feedback on progress

This commit is contained in:
Ravi Shankar 2016-02-21 19:38:43 +05:30
parent 3f74c07e20
commit 78a966c547
3 changed files with 82 additions and 53 deletions

View file

@ -94,10 +94,12 @@ class MachCommands(CommandBase):
@CommandArgument('--release', default=False, action="store_true",
help="Run with a release build of servo")
@CommandArgument('--faster', default=False, action="store_true",
help="Only check changed files and skip the WPT lint")
def test(self, params, render_mode=DEFAULT_RENDER_MODE, release=False, faster=False):
help="Only check changed files and skip the WPT lint in tidy")
@CommandArgument('--no-progress', default=False, action="store_true",
help="Don't show progress for tidy")
def test(self, params, render_mode=DEFAULT_RENDER_MODE, release=False, faster=False, no_progress=False):
suites = OrderedDict([
("tidy", {"kwargs": {"faster": faster},
("tidy", {"kwargs": {"faster": faster, "no_progress": no_progress},
"include_arg": "include"}),
("ref", {"kwargs": {"kind": render_mode},
"paths": [path.abspath(path.join("tests", "ref"))],
@ -292,9 +294,11 @@ class MachCommands(CommandBase):
description='Run the source code tidiness check',
category='testing')
@CommandArgument('--faster', default=False, action="store_true",
help="Only check changed files and skip the WPT lint")
def test_tidy(self, faster):
return tidy.scan(faster)
help="Only check changed files and skip the WPT lint in tidy")
@CommandArgument('--no-progress', default=False, action="store_true",
help="Don't show progress for tidy")
def test_tidy(self, faster, no_progress):
return tidy.scan(faster, not no_progress)
@Command('test-webidl',
description='Run the WebIDL parser tests',