Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #12598 - vrod:add-test-dialog-open, r=KiChjang

Browse source 
Write a test for HTMLDialogElement#open

<!-- Please describe your changes on the following line: -->
Write a test for HTMLDialogElement#open.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12574.
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12598)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-07-26 18:42:58 -05:00 • committed by GitHub
commit 78e9b84a8b
2 changed files with 36 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/wpt/metadata/MANIFEST.json
View file

@ -37205,6 +37205,12 @@
"deleted_reftests": {},
"items": {
"testharness": {
"html/semantics/interactive-elements/the-dialog-element/dialog-open.html": [
{
"path": "html/semantics/interactive-elements/the-dialog-element/dialog-open.html",
"url": "/html/semantics/interactive-elements/the-dialog-element/dialog-open.html"
}
],
"html/semantics/scripting-1/the-script-element/script-charset-03.html": [
{
"path": "html/semantics/scripting-1/the-script-element/script-charset-03.html",

30
tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open.html Normal file
View file

@ -0,0 +1,30 @@
<!doctype html>
<meta charset="utf-8">
<title>dialog element: open</title>
<link rel=help href="https://html.spec.whatwg.org/multipage/forms.html#dom-dialog-open">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<dialog id="d1">
<p>foobar</p>
<button>OK</button>
</dialog>
<dialog id="d2" open>
<p>foobar</p>
<button>OK</button>
</dialog>
<script>
var d1 = document.getElementById('d1');
var d2 = document.getElementById('d2');
test(function(){
assert_false(d1.open);
assert_true(d2.open);
}, "On getting, the IDL open attribute must return true if the content open attribute is set, and false if it is absent.");
test(function(){
d1.open = true;
assert_true(d1.hasAttribute("open"));
d2.open = false;
assert_false(d2.hasAttribute("open"));
}, "On setting, the content open attribute must be removed if the IDL open attribute is set to false, and must be present if the IDL open attribute is set to true.");
</script>