mirror of
https://github.com/servo/servo.git
synced 2025-08-08 15:05:35 +01:00
style: Disregard the size
attribute for input elements other than text
or password fields. HTML5 § 4.10.5.3.2 doesn't explicitly say to do this, but all other browser engines seem to do it. Improves the Google home page.
This commit is contained in:
parent
211ee668fa
commit
79336d21b5
5 changed files with 35 additions and 18 deletions
|
@ -167,25 +167,23 @@ impl PresentationalHintSynthesis for Stylist {
|
|||
shareable);
|
||||
}
|
||||
name if *name == atom!("input") => {
|
||||
match element.get_integer_attribute(IntegerAttribute::Size) {
|
||||
Some(value) if value != 0 => {
|
||||
// Per HTML 4.01 § 17.4, this value is in characters if `type` is `text` or
|
||||
// `password` and in pixels otherwise.
|
||||
//
|
||||
// FIXME(pcwalton): More use of atoms, please!
|
||||
let value = match element.get_attr(&ns!(""), &atom!("type")) {
|
||||
Some("text") | Some("password") => {
|
||||
specified::Length::ServoCharacterWidth(specified::CharacterWidth(value))
|
||||
// FIXME(pcwalton): More use of atoms, please!
|
||||
match element.get_attr(&ns!(""), &atom!("type")) {
|
||||
Some("text") | Some("password") => {
|
||||
match element.get_integer_attribute(IntegerAttribute::Size) {
|
||||
Some(value) if value != 0 => {
|
||||
let value = specified::Length::ServoCharacterWidth(
|
||||
specified::CharacterWidth(value));
|
||||
matching_rules_list.vec_push(from_declaration(
|
||||
PropertyDeclaration::Width(SpecifiedValue(
|
||||
specified::LengthOrPercentageOrAuto::Length(value)))));
|
||||
*shareable = false
|
||||
}
|
||||
_ => specified::Length::Absolute(Au::from_px(value as isize)),
|
||||
};
|
||||
matching_rules_list.vec_push(from_declaration(
|
||||
PropertyDeclaration::Width(SpecifiedValue(
|
||||
specified::LengthOrPercentageOrAuto::Length(value)))));
|
||||
*shareable = false
|
||||
Some(_) | None => {}
|
||||
}
|
||||
}
|
||||
Some(_) | None => {}
|
||||
}
|
||||
_ => {}
|
||||
};
|
||||
}
|
||||
name if *name == atom!("textarea") => {
|
||||
match element.get_integer_attribute(IntegerAttribute::Cols) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue