Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Trigger wakeup when queuing, not when processing

Browse source
This commit is contained in:
Manish Goregaokar 2019-01-15 14:13:58 -08:00
parent d0a6884b2c
commit 798c88917b
1 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
components/script/dom/vrdisplay.rs
View file

@ -437,8 +437,10 @@ impl VRDisplayMethods for VRDisplay {
let display_id = self.display.borrow().display_id; let display_id = self.display.borrow().display_id;
let layer = self.layer.borrow(); let layer = self.layer.borrow();
let msg = WebVRCommand::SubmitFrame(display_id, layer.left_bounds, layer.right_bounds); let msg = WebVRCommand::SubmitFrame(display_id, layer.left_bounds, layer.right_bounds);
self.layer_ctx.get().expect("SubmitFrame can only be called when there is a webgl layer") self.layer_ctx
.send_vr_command(msg); .get()
.expect("SubmitFrame can only be called when there is a webgl layer")
.send_vr_command(msg);
} }
// https://w3c.github.io/webvr/spec/1.1/#dom-vrdisplay-getlayers // https://w3c.github.io/webvr/spec/1.1/#dom-vrdisplay-getlayers
@ -616,16 +618,19 @@ impl VRDisplay {
depthFar: state.depthFar, depthFar: state.depthFar,
baseLayer: state.baseLayer.clone(), baseLayer: state.baseLayer.clone(),
}; };
self.pending_renderstate_updates.borrow_mut().push((new_state, promise)) self.pending_renderstate_updates
.borrow_mut()
.push((new_state, promise));
if let Some(ref wakeup) = *self.raf_wakeup_sender.borrow() {
let _ = wakeup.send(());
}
} }
fn process_renderstate_queue(&self) { fn process_renderstate_queue(&self) {
let mut updates = self.pending_renderstate_updates.borrow_mut(); let mut updates = self.pending_renderstate_updates.borrow_mut();
if updates.is_empty() {
return;
}
debug_assert!(self.xr_session.get().is_some()); debug_assert!(updates.is_empty() || self.xr_session.get().is_some());
for update in updates.drain(..) { for update in updates.drain(..) {
if let Some(near) = update.0.depthNear { if let Some(near) = update.0.depthNear {
self.depth_near.set(*near); self.depth_near.set(*near);
@ -640,10 +645,6 @@ impl VRDisplay {
} }
update.1.resolve_native(&()); update.1.resolve_native(&());
} }
if let Some(ref wakeup) = *self.raf_wakeup_sender.borrow() {
let _ = wakeup.send(());
}
} }
fn init_present(&self) { fn init_present(&self) {