From 79e0f19221e4ad14ab5dbf15a6d4c7cf110f18a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Wed, 20 Dec 2017 22:57:39 +0100 Subject: [PATCH] style: Workaround a likely valgrind false-positive. --- components/style/selector_map.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/components/style/selector_map.rs b/components/style/selector_map.rs index ef70949da68..c7c41c6de44 100644 --- a/components/style/selector_map.rs +++ b/components/style/selector_map.rs @@ -433,7 +433,13 @@ fn specific_bucket_for<'a>( // // So inserting `span` in the rule hash makes sense since we want to // match the slotted . - Component::Slotted(ref selector) => find_bucket(selector.iter()), + // + // FIXME(emilio, bug 1426516): The line below causes valgrind failures + // and it's probably a false positive, we should uncomment whenever + // jseward is back to confirm / whitelist it. + // + // Meanwhile taking the code path below is slower, but still correct. + // Component::Slotted(ref selector) => find_bucket(selector.iter()), _ => Bucket::Universal } }