From 7b019f807b9044c522c3a8b8c2ac9f012083b3ec Mon Sep 17 00:00:00 2001 From: Bobby Holley Date: Tue, 12 Sep 2017 12:36:41 -0700 Subject: [PATCH] Use inheritance_parent to control style_sharing. Using traversal_parent here is wrong. MozReview-Commit-ID: GHCIjkgx4VE --- components/style/sharing/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/style/sharing/mod.rs b/components/style/sharing/mod.rs index 6aecbd3e3d0..47f82e1a095 100644 --- a/components/style/sharing/mod.rs +++ b/components/style/sharing/mod.rs @@ -582,7 +582,7 @@ impl StyleSharingCache { return None; } - if target.traversal_parent().is_none() { + if target.inheritance_parent().is_none() { debug!("{:?} Cannot share style: element has no parent", target.element); return None; @@ -615,8 +615,8 @@ impl StyleSharingCache { // share styles and permit sharing across their children. The latter // check allows us to share style between cousins if the parents // shared style. - let parent = target.traversal_parent(); - let candidate_parent = candidate.element.traversal_parent(); + let parent = target.inheritance_parent(); + let candidate_parent = candidate.element.inheritance_parent(); if parent != candidate_parent && !checks::can_share_style_across_parents(parent, candidate_parent) { trace!("Miss: Parent");