Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 21:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't require index parameter in CSSGroupingRule's insertRule() (#35295)

Browse source 
Make it optional, defaulting to 0 if omitted, as defined in the spec:
https://drafts.csswg.org/cssom/#ref-for-dom-cssgroupingrule-insertrule

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2025-02-05 13:41:36 +01:00 • committed by GitHub
parent 07aa4ce093
commit 7b36f2beb3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script_bindings/webidls/CSSGroupingRule.webidl
View file

@ -6,7 +6,7 @@
[Abstract, Exposed=Window] [Abstract, Exposed=Window]
interface CSSGroupingRule : CSSRule { interface CSSGroupingRule : CSSRule {
[SameObject] readonly attribute CSSRuleList cssRules; [SameObject] readonly attribute CSSRuleList cssRules;
[Throws] unsigned long insertRule(DOMString rule, unsigned long index); [Throws] unsigned long insertRule(DOMString rule, optional unsigned long index = 0);
[Throws] undefined deleteRule(unsigned long index); [Throws] undefined deleteRule(unsigned long index);
}; };

4
tests/wpt/meta/css/cssom/CSSGroupingRule-insertRule.html.ini vendored
View file

@ -1,4 +0,0 @@
[CSSGroupingRule-insertRule.html]
[index not specified]
expected: FAIL

3
tests/wpt/meta/css/cssom/idlharness.html.ini vendored
View file

@ -215,9 +215,6 @@
[CSSRule interface: sheet.cssRules[2\].cssRules[0\] must inherit property "MARGIN_RULE" with the proper type] [CSSRule interface: sheet.cssRules[2\].cssRules[0\] must inherit property "MARGIN_RULE" with the proper type]
expected: FAIL expected: FAIL
[CSSGroupingRule interface: operation insertRule(CSSOMString, optional unsigned long)]
expected: FAIL
[CSSImportRule interface: sheet.cssRules[0\] must inherit property "styleSheet" with the proper type] [CSSImportRule interface: sheet.cssRules[0\] must inherit property "styleSheet" with the proper type]
expected: FAIL expected: FAIL