Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-02 20:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Introduce VirtualMethods::children_changed()

Browse source 
This virtual method mimics the behaviour of mutation observers and make it more
viable than the older child_inserted(), which didn't cover removed nodes and
was called as many times as there were inserted nodes.

A few other shortcomings where remove_child() was called directly instead of
Node::remove() were also fixed while at it.
This commit is contained in:
Anthony Ramine 2015-07-18 14:45:52 +02:00
parent 389a9ff643
commit 7b40cc9fd7
7 changed files with 194 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/htmltitleelement.rs
View file

@ -13,7 +13,7 @@ use dom::document::{Document, DocumentHelpers};
use dom::eventtarget::{EventTarget, EventTargetTypeId};
use dom::element::ElementTypeId;
use dom::htmlelement::{HTMLElement, HTMLElementTypeId};
use dom::node::{Node, NodeHelpers, NodeTypeId};
use dom::node::{ChildrenMutation, Node, NodeHelpers, NodeTypeId};
use dom::text::Text;
use dom::virtualmethods::VirtualMethods;
use util::str::DOMString;
@ -75,15 +75,13 @@ impl<'a> VirtualMethods for &'a HTMLTitleElement {
Some(htmlelement as &VirtualMethods)
}
fn child_inserted(&self, child: &Node) {
fn children_changed(&self, mutation: &ChildrenMutation) {
if let Some(ref s) = self.super_type() {
s.child_inserted(child);
s.children_changed(mutation);
}
let node = NodeCast::from_ref(*self);
if node.is_in_doc() {
let document = node.owner_doc();
document.r().title_changed();
node.owner_doc().title_changed();
}
}