Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

auto merge of #5198 : ienzam/servo/force_relayout_cleanup, r=jdm

Browse source 
This is a cleanup for issue #3959 

Do I need to inline force_relayout?
This commit is contained in:
bors-servo 2015-03-11 14:12:50 -06:00
commit 7b6e314df1
1 changed files with 0 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/htmlinputelement.rs
View file

@ -245,7 +245,6 @@ impl<'a> HTMLInputElementMethods for JSRef<'a, HTMLInputElement> {
fn SetValue(self, value: DOMString) {
self.textinput.borrow_mut().set_content(value);
self.value_changed.set(true);
self.force_relayout();
}
// https://html.spec.whatwg.org/multipage/forms.html#dom-input-defaultvalue
@ -383,7 +382,6 @@ impl<'a> HTMLInputElementHelpers for JSRef<'a, HTMLInputElement> {
.map(|group| group.as_slice()));
}
//TODO: dispatch change event
self.force_relayout();
}
fn get_size(&self) -> u32 {
@ -446,7 +444,6 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLInputElement> {
AttrValue::UInt(_, value) => self.size.set(value),
_ => panic!("Expected an AttrValue::UInt"),
}
self.force_relayout();
}
&atom!("type") => {
let value = attr.value();
@ -465,12 +462,10 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLInputElement> {
.as_ref()
.map(|group| group.as_slice()));
}
self.force_relayout();
}
&atom!("value") => {
if !self.value_changed.get() {
self.textinput.borrow_mut().set_content(attr.value().as_slice().to_owned());
self.force_relayout();
}
}
&atom!("name") => {
@ -503,7 +498,6 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLInputElement> {
}
&atom!("size") => {
self.size.set(DEFAULT_INPUT_SIZE);
self.force_relayout();
}
&atom!("type") => {
if self.input_type.get() == InputType::InputRadio {
@ -513,12 +507,10 @@ impl<'a> VirtualMethods for JSRef<'a, HTMLInputElement> {
.map(|group| group.as_slice()));
}
self.input_type.set(InputType::InputText);
self.force_relayout();
}
&atom!("value") => {
if !self.value_changed.get() {
self.textinput.borrow_mut().set_content("".to_owned());
self.force_relayout();
}
}
&atom!("name") => {