Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 15:23:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: Fix some warnings in script/dom (#31915)

Browse source 
* fixed some clippy warnings

* resolved conflict

* updated texttracklist.rs

---------

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Ekta Siwach 2024-03-28 22:27:25 +05:30 • committed by GitHub
parent 9303c90159
commit 7ce78f5a74
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/texttrack.rs
View file

@ -142,7 +142,7 @@ impl TextTrackMethods for TextTrack {
// gecko calls RemoveCue when the given cue // gecko calls RemoveCue when the given cue
// has an associated track, but doesn't return // has an associated track, but doesn't return
// the error from it, so we wont either. // the error from it, so we wont either.
if let Err(_) = old_track.RemoveCue(cue) { if old_track.RemoveCue(cue).is_err() {
warn!("Failed to remove cues for the added cue's text track"); warn!("Failed to remove cues for the added cue's text track");
} }
} }

6
components/script/dom/texttrackcuelist.rs
View file

@ -42,8 +42,7 @@ impl TextTrackCueList {
.borrow() .borrow()
.iter() .iter()
.enumerate() .enumerate()
.filter(|(_, c)| **c == cue) .find(|(_, c)| **c == cue)
.next()
.map(|(i, _)| i) .map(|(i, _)| i)
} }
@ -78,8 +77,7 @@ impl TextTrackCueListMethods for TextTrackCueList {
self.dom_cues self.dom_cues
.borrow() .borrow()
.iter() .iter()
.filter(|cue| cue.id() == id) .find(|cue| cue.id() == id)
.next()
.map(|t| DomRoot::from_ref(&**t)) .map(|t| DomRoot::from_ref(&**t))
} }
} }

6
components/script/dom/texttracklist.rs
View file

@ -49,8 +49,7 @@ impl TextTrackList {
.borrow() .borrow()
.iter() .iter()
.enumerate() .enumerate()
.filter(|(_, t)| **t == track) .find(|(_, t)| **t == track)
.next()
.map(|(i, _)| i) .map(|(i, _)| i)
} }
@ -125,8 +124,7 @@ impl TextTrackListMethods for TextTrackList {
self.dom_tracks self.dom_tracks
.borrow() .borrow()
.iter() .iter()
.filter(|track| track.id() == id_str) .find(|track| track.id() == id_str)
.next()
.map(|t| DomRoot::from_ref(&**t)) .map(|t| DomRoot::from_ref(&**t))
} }