Remove Snapshot::from_shared_memory to avoid double allocation (#37562)

It was always misused, causing extra allocations all over the place.
Discovered in
https://github.com/servo/servo/pull/37560#discussion_r2157222917

Testing: WPT tests

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
sagudev 2025-06-20 04:09:09 +02:00 committed by GitHub
parent a97cde0a6f
commit 7d1d50f703
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 22 deletions

View file

@ -17,7 +17,7 @@ use cssparser::color::clamp_unit_f32;
use cssparser::{Parser, ParserInput};
use euclid::default::{Point2D, Rect, Size2D, Transform2D};
use euclid::vec2;
use ipc_channel::ipc::{self, IpcSender, IpcSharedMemory};
use ipc_channel::ipc::{self, IpcSender};
use net_traits::image_cache::{ImageCache, ImageResponse};
use net_traits::request::CorsSettings;
use pixels::PixelFormat;
@ -358,11 +358,11 @@ impl CanvasState {
premultiplied: false,
};
Some(snapshot::Snapshot::from_shared_memory(
Some(snapshot::Snapshot::from_vec(
size.cast(),
format,
alpha_mode,
IpcSharedMemory::from_bytes(img.first_frame().bytes),
img.first_frame().bytes.to_vec(),
))
}