Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-15 19:33:46 +01:00
Code Issues Projects Releases Packages Wiki Activity

added test and assertion that profiler statistics data must be sorted

Browse source
This commit is contained in:
Malisa Smith 2016-07-07 12:59:16 -07:00
parent d47b769cf7
commit 7dccf09ff6
2 changed files with 22 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/profile/time.rs
View file

@ -328,12 +328,17 @@ impl Profiler {
} }
pub fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) { pub fn get_statistics(data: &[f64]) -> (f64, f64, f64, f64) {
let data_len = data.len(); data.iter().fold(-f64::INFINITY, |a, &b| {
let (mean, median, min, max) = debug_assert!(a < b, "Data must be sorted");
(data.iter().sum::<f64>() / (data_len as f64), b
data[data_len / 2], });
data.iter().fold(f64::INFINITY, |a, &b| a.min(b)),
data.iter().fold(-f64::INFINITY, |a, &b| a.max(b))); let data_len = data.len();
let (mean, median, min, max) =
(data.iter().sum::<f64>() / (data_len as f64),
data[data_len / 2],
data.iter().fold(f64::INFINITY, |a, &b| a.min(b)),
data.iter().fold(-f64::INFINITY, |a, &b| a.max(b)));
(mean, median, min, max) (mean, median, min, max)
} }

14
tests/unit/profile/time.rs
View file

@ -17,8 +17,8 @@ fn time_profiler_smoke_test() {
} }
#[test] #[test]
fn time_profilers_stats_test() { fn time_profiler_stats_test() {
let even_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \ let even_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345,
9.2345, 10.2342345, 13.2599, 15.0]; 9.2345, 10.2342345, 13.2599, 15.0];
let (even_mean, even_median, even_min, even_max) = time::Profiler::get_statistics(&even_data); let (even_mean, even_median, even_min, even_max) = time::Profiler::get_statistics(&even_data);
@ -27,7 +27,7 @@ fn time_profilers_stats_test() {
assert_eq!(1.234, even_min); assert_eq!(1.234, even_min);
assert_eq!(15.0, even_max); assert_eq!(15.0, even_max);
let odd_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345, \ let odd_data = vec![1.234, 3.24567, 3.54578, 5.0, 5.324, 7.345,
9.2345, 10.2342345, 13.2599]; 9.2345, 10.2342345, 13.2599];
let (odd_mean, odd_median, odd_min, odd_max) = time::Profiler::get_statistics(&odd_data); let (odd_mean, odd_median, odd_min, odd_max) = time::Profiler::get_statistics(&odd_data);
@ -36,3 +36,11 @@ fn time_profilers_stats_test() {
assert_eq!(1.234, odd_min); assert_eq!(1.234, odd_min);
assert_eq!(13.2599, odd_max); assert_eq!(13.2599, odd_max);
} }
#[cfg(debug)]
#[test]
#[should_panic]
fn time_profiler_unsorted_stats_test() {
let unsorted_data = vec![5.0, 7.5, 1.0, 8.9];
time::Profiler::get_statistics(&unsorted_data);
}