From 7e4cf13f5b1106690f15d84029e31364c0c6907b Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Thu, 19 Sep 2019 17:43:48 -0400 Subject: [PATCH] webgl: Support RGB color attachments for complete framebuffers. --- components/script/dom/webglframebuffer.rs | 1 + .../conformance/textures/misc/tex-input-validation.html.ini | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/components/script/dom/webglframebuffer.rs b/components/script/dom/webglframebuffer.rs index 114ede38b01..284a51cf483 100644 --- a/components/script/dom/webglframebuffer.rs +++ b/components/script/dom/webglframebuffer.rs @@ -177,6 +177,7 @@ impl WebGLFramebuffer { constants::RGB5_A1, constants::RGB565, constants::RGBA, + constants::RGB, ][..], &[constants::DEPTH_COMPONENT16][..], &[constants::STENCIL_INDEX8][..], diff --git a/tests/wpt/webgl/meta/conformance/textures/misc/tex-input-validation.html.ini b/tests/wpt/webgl/meta/conformance/textures/misc/tex-input-validation.html.ini index a5e193befaf..9611a8b8c64 100644 --- a/tests/wpt/webgl/meta/conformance/textures/misc/tex-input-validation.html.ini +++ b/tests/wpt/webgl/meta/conformance/textures/misc/tex-input-validation.html.ini @@ -6,9 +6,5 @@ [WebGL test #61: getError expected: INVALID_OPERATION. Was NO_ERROR : colorBufferFormat: RGB internalFormat: RGBA] expected: FAIL - [WebGL test #53: getError expected: INVALID_OPERATION. Was NO_ERROR : colorBufferFormat: RGB internalFormat: RGBA] + [WebGL test #37: getError expected: NO_ERROR. Was INVALID_OPERATION : colorBufferFormat: RGB565 internalFormat: RGB target: TEXTURE_2D border: 0] expected: FAIL - - [WebGL test #34: getError expected: INVALID_OPERATION. Was NO_ERROR : colorBufferFormat: RGB565 internalFormat: RGBA target: TEXTURE_2D border: 0] - expected: FAIL -