Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 08:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Reverse vertical orientation of gradients using corner directions. (#37802)

Browse source 
Found and manually tested by comparing rendering between Firefox and
Servo.

Testing: Existing WPT coverage is sufficient.
Fixes: #37782

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-07-11 16:02:13 -04:00 • committed by GitHub
parent c5aeac3cea
commit 7eedeca715
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/layout/display_list/gradient.rs
View file

@ -138,8 +138,8 @@ pub(super) fn build_linear(
Left => -gradient_box.height, Left => -gradient_box.height,
}; };
let y = match vertical { let y = match vertical {
Top => gradient_box.width, Top => -gradient_box.width,
Bottom => -gradient_box.width, Bottom => gradient_box.width,
}; };
// `{ x, y }` is now a vector of arbitrary length // `{ x, y }` is now a vector of arbitrary length

17
tests/wpt/meta/MANIFEST.json vendored
View file

@ -204735,6 +204735,19 @@
{} {}
] ]
], ],
"linear-gradient-non-square.html": [
"2b4f48990f24bd74ec638d39a5f569f56cb63664",
[
null,
[
[
"/css/css-images/reference/linear-gradient-non-square-ref.html",
"=="
]
],
{}
]
],
"linear-gradient-sibling-index.html": [ "linear-gradient-sibling-index.html": [
"b92897e0697441df6876b88e53daa148a5edb009", "b92897e0697441df6876b88e53daa148a5edb009",
[ [
@ -440282,6 +440295,10 @@
"200x200-blue-black-green-red.html": [ "200x200-blue-black-green-red.html": [
"04322b066c316b8b89c73d966e00f607447edd8e", "04322b066c316b8b89c73d966e00f607447edd8e",
[] []
],
"linear-gradient-non-square-ref.html": [
"1ad3c75747e05768a3e79d879e535e8b3980f1a4",
[]
] ]
}, },
"repeating-conic-gradient-ref.html": [ "repeating-conic-gradient-ref.html": [

17
tests/wpt/mozilla/meta/MANIFEST.json vendored
View file

@ -3952,19 +3952,6 @@
{} {}
] ]
], ],
"linear_gradients_non_square_a.html": [
"2edd6cbaa4638d6fdc474c6e7bec7f4c194dc721",
[
null,
[
[
"/_mozilla/css/linear_gradients_non_square_ref.html",
"=="
]
],
{}
]
],
"linear_gradients_parsing_a.html": [ "linear_gradients_parsing_a.html": [
"c2e18fb98ed4324f8337290cbae84b14df580182", "c2e18fb98ed4324f8337290cbae84b14df580182",
[ [
@ -9324,10 +9311,6 @@
"a067067fff64d232aad7233b69b7b78e74e1f365", "a067067fff64d232aad7233b69b7b78e74e1f365",
[] []
], ],
"linear_gradients_non_square_ref.html": [
"1ad3c75747e05768a3e79d879e535e8b3980f1a4",
[]
],
"linear_gradients_parsing_ref.html": [ "linear_gradients_parsing_ref.html": [
"b4d21f1c85bfd1da96a35f2c09e73ee9d561ecd9", "b4d21f1c85bfd1da96a35f2c09e73ee9d561ecd9",
[] []

3
tests/wpt/mozilla/tests/css/linear_gradients_non_square_a.html → tests/wpt/tests/css/css-images/linear-gradient-non-square.html vendored
View file

@ -1,7 +1,8 @@
<!doctype html> <!doctype html>
<meta charset="utf-8"> <meta charset="utf-8">
<title>Linear gradients for non-square elements</title> <title>Linear gradients for non-square elements</title>
<link rel="match" href="linear_gradients_non_square_ref.html"> <link rel="help" href="https://drafts.csswg.org/css-images/#linear-gradients">
<link rel="match" href="reference/linear-gradient-non-square-ref.html">
<style> <style>
.a, .a,
.b, .b,

0
tests/wpt/mozilla/tests/css/linear_gradients_non_square_ref.html → tests/wpt/tests/css/css-images/reference/linear-gradient-non-square-ref.html vendored
View file