Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Check mode first in gl.drawElements

Browse source
This commit is contained in:
Anthony Ramine 2018-04-16 16:22:42 +02:00
parent 1c9bbce38c
commit 7f1590dac0
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
components/script/dom/webglrenderingcontext.rs
View file

@ -2143,6 +2143,14 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.11 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.11
fn DrawElements(&self, mode: u32, count: i32, type_: u32, offset: i64) { fn DrawElements(&self, mode: u32, count: i32, type_: u32, offset: i64) {
match mode {
constants::POINTS | constants::LINE_STRIP |
constants::LINE_LOOP | constants::LINES |
constants::TRIANGLE_STRIP | constants::TRIANGLE_FAN |
constants::TRIANGLES => {},
_ => return self.webgl_error(InvalidEnum),
}
// From the GLES 2.0.25 spec, page 21: // From the GLES 2.0.25 spec, page 21:
// //
// "type must be one of UNSIGNED_BYTE or UNSIGNED_SHORT" // "type must be one of UNSIGNED_BYTE or UNSIGNED_SHORT"
@ -2194,16 +2202,8 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
return; return;
} }
match mode { self.send_command(WebGLCommand::DrawElements(mode, count, type_, offset));
constants::POINTS | constants::LINE_STRIP | self.mark_as_dirty();
constants::LINE_LOOP | constants::LINES |
constants::TRIANGLE_STRIP | constants::TRIANGLE_FAN |
constants::TRIANGLES => {
self.send_command(WebGLCommand::DrawElements(mode, count, type_, offset));
self.mark_as_dirty();
},
_ => self.webgl_error(InvalidEnum),
}
} }
// https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10 // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.10