Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Workaround bug in gstreamer binaries

Browse source 
The official gstreamer .pkg distribution should contain
'relocatable' dylibs, but as discovered in #29732,
some dylibs have absolute links to liblzma.5.dylibs

Since /opt/homebrew is the default install location
on Apple Silicion, this will cause the packaging &
build steps to fail, even if 'xz' package is installed
via homebrew.

This is a temporary fix until upstream fixes the bug
and makes the package truly 'relocatable'.

Signed-off-by: Mukilan Thiyagarajan <me@mukilan.in>
This commit is contained in:
Mukilan Thiyagarajan 2023-05-12 19:03:47 +05:30
parent d798376d7c
commit 80087f31c8
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
python/servo/build_commands.py
View file

@ -872,6 +872,17 @@ def copy_dependencies(binary_path, lib_path, gst_root):
if is_system_library(f):
continue
full_path = resolve_rpath(f, gst_root)
# fixme(mukilan): this is a temporary solution to a bug
# in the official gstreamer packages. Few gstreamer dylibs
# like 'libavcodec.59.dylib' have absolute paths to liblzma
# instead of @rpath based to be relocatable. The homebrew
# prefix is configurable in general and is /opt/homebrew
# on Apple Silicon
if full_path == "/usr/local/opt/xz/lib/liblzma.5.dylib" and (
not path.exists("/usr/local/opt/xz")
and path.exists("/opt/homebrew/")):
full_path = "/opt/homebrew/lib/liblzma.5.dylib"
need_relinked = set(otool(full_path))
new_path = path.join(lib_path, path.basename(full_path))
if not path.exists(new_path):