Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Stop having text alignment stomp on layerization flags.

Browse source 
Fixes the blank spaces showing up in Wikipedia.
This commit is contained in:
Patrick Walton 2014-12-01 10:52:36 -08:00
parent 12ae541302
commit 803624c51e
2 changed files with 14 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/layout/block.rs
View file

@ -1737,7 +1737,9 @@ impl Flow for BlockFlow {
.stacking_relative_position_of_absolute_containing_block .stacking_relative_position_of_absolute_containing_block
}, },
relative_containing_block_size: self.fragment.content_box().size, relative_containing_block_size: self.fragment.content_box().size,
layers_needed_for_positioned_flows: self.base.flags.contains(LAYERS_NEEDED_FOR_DESCENDANTS), layers_needed_for_positioned_flows: self.base
.flags
.contains(LAYERS_NEEDED_FOR_DESCENDANTS),
}; };
// Compute the origin and clipping rectangle for children. // Compute the origin and clipping rectangle for children.

21
components/layout/flow.rs
View file

@ -497,8 +497,10 @@ bitflags! {
#[doc = "Whether this flow is right-floated. This is checked all over layout, so a"] #[doc = "Whether this flow is right-floated. This is checked all over layout, so a"]
#[doc = "virtual call is too expensive."] #[doc = "virtual call is too expensive."]
const FLOATS_RIGHT = 0b0000_0100_0000_0000, const FLOATS_RIGHT = 0b0000_0100_0000_0000,
#[doc = "Text alignment."] #[doc = "Text alignment. \
const TEXT_ALIGN = 0b0000_1000_0000_0000,
NB: If you update this, update `TEXT_ALIGN_SHIFT` below."]
const TEXT_ALIGN = 0b0111_1000_0000_0000,
} }
} }
@ -508,12 +510,10 @@ bitflags! {
static HAS_FLOATED_DESCENDANTS_BITMASK: FlowFlags = FlowFlags { bits: 0b0000_0011 }; static HAS_FLOATED_DESCENDANTS_BITMASK: FlowFlags = FlowFlags { bits: 0b0000_0011 };
// NB: If you update this field, you must update the the text align flags.
/// The bitmask of flags that represent the text alignment field.
static TEXT_ALIGN_BITMASK: FlowFlags = FlowFlags { bits: 0b0011_0000 };
/// The number of bits we must shift off to handle the text alignment field. /// The number of bits we must shift off to handle the text alignment field.
static TEXT_ALIGN_SHIFT: uint = 4; ///
/// NB: If you update this, update `TEXT_ALIGN` above.
static TEXT_ALIGN_SHIFT: uint = 11;
impl FlowFlags { impl FlowFlags {
/// Propagates text alignment flags from an appropriate parent flow per CSS 2.1. /// Propagates text alignment flags from an appropriate parent flow per CSS 2.1.
@ -526,17 +526,18 @@ impl FlowFlags {
#[inline] #[inline]
pub fn text_align(self) -> text_align::T { pub fn text_align(self) -> text_align::T {
FromPrimitive::from_u16((self & TEXT_ALIGN_BITMASK).bits() >> TEXT_ALIGN_SHIFT).unwrap() FromPrimitive::from_u16((self & TEXT_ALIGN).bits() >> TEXT_ALIGN_SHIFT).unwrap()
} }
#[inline] #[inline]
pub fn set_text_align(&mut self, value: text_align::T) { pub fn set_text_align(&mut self, value: text_align::T) {
*self = (*self & !TEXT_ALIGN_BITMASK) | FlowFlags::from_bits(value as u16 << TEXT_ALIGN_SHIFT).unwrap(); *self = (*self & !TEXT_ALIGN) |
FlowFlags::from_bits(value as u16 << TEXT_ALIGN_SHIFT).unwrap();
} }
#[inline] #[inline]
pub fn set_text_align_override(&mut self, parent: FlowFlags) { pub fn set_text_align_override(&mut self, parent: FlowFlags) {
self.insert(parent & TEXT_ALIGN_BITMASK); self.insert(parent & TEXT_ALIGN);
} }
#[inline] #[inline]