mirror of
https://github.com/servo/servo.git
synced 2025-08-03 20:50:07 +01:00
Make Restyle tracking more granular.
The primary idea of this patch is to ditch the rigid enum of Previous/Current styles, and replace it with a series of indicators for the various types of work that needs to be performed (expanding snapshots, rematching, recascading, and damage processing). This loses us a little bit of sanity checking (since the up-to-date-ness of our style is no longer baked into the type system), but gives us a lot more flexibility that we'll need going forward (especially when we separate matching from cascading). We also eliminate get_styling_mode in favor of a method on the traversal. This patch does a few other things as ridealongs: * Temporarily eliminates the handling for transfering ownership of styles to the frame. We'll need this again at some point, but for now it's causing too much complexity for a half-implemented feature. * Ditches TRestyleDamage, which is no longer necessary post-crate-merge, and is a constant source of compilation failures from either needing to be imported or being unnecessarily imported (which varies between gecko and servo). * Expands Snapshots for the traversal root, which was missing before. * Fixes up the skip_root stuff to avoid visiting the skipped root. * Unifies parallel traversal and avoids spawning for a single work item. * Adds an explicit pre_traverse step do any pre-processing and determine whether we need to traverse at all. MozReview-Commit-ID: IKhLAkAigXE
This commit is contained in:
parent
4cb3404c09
commit
80460cc549
27 changed files with 502 additions and 474 deletions
|
@ -8,6 +8,7 @@ use cssparser::Parser as CssParser;
|
|||
use matching::{common_style_affecting_attributes, CommonStyleAffectingAttributeMode};
|
||||
use selectors::Element;
|
||||
use selectors::parser::{AttrSelector, SelectorList};
|
||||
use std::fmt::Debug;
|
||||
use stylesheets::{Origin, Namespaces};
|
||||
|
||||
pub type AttrValue = <SelectorImpl as ::selectors::SelectorImpl>::AttrValue;
|
||||
|
@ -30,6 +31,12 @@ pub use servo::restyle_damage::ServoRestyleDamage as RestyleDamage;
|
|||
#[cfg(feature = "gecko")]
|
||||
pub use gecko::restyle_damage::GeckoRestyleDamage as RestyleDamage;
|
||||
|
||||
#[cfg(feature = "servo")]
|
||||
pub type PreExistingComputedValues = ::std::sync::Arc<::properties::ServoComputedValues>;
|
||||
|
||||
#[cfg(feature = "gecko")]
|
||||
pub type PreExistingComputedValues = ::gecko_bindings::structs::nsStyleContext;
|
||||
|
||||
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
|
||||
pub struct SelectorParser<'a> {
|
||||
pub stylesheet_origin: Origin,
|
||||
|
@ -99,7 +106,7 @@ impl PseudoElementCascadeType {
|
|||
}
|
||||
}
|
||||
|
||||
pub trait ElementExt: Element<Impl=SelectorImpl> {
|
||||
pub trait ElementExt: Element<Impl=SelectorImpl> + Debug {
|
||||
fn is_link(&self) -> bool;
|
||||
|
||||
fn matches_user_and_author_rules(&self) -> bool;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue